Repository navigation
OpenSSL 4.x dropped the macro OPENSSL_NO_SSL3 - #24352
Open
rainerjung wants to merge 1 commit into
Open
rainerjung wants to merge 1 commit into
rainerjung wants to merge 1 commit into
Conversation
Trying to detect missing SSLv3 support by checking OPENSSL_NO_SSL3 fails since OpenSSL 4, so the code assumes SSLv3 is available, but it is not.
Author
|
The failing test doesn't have to do with this PR. It seems the FreeBSD test system is not available? |
Member
|
@ramsey @saundefined is it a worthy backport ? |
Author
|
I only set 8.2 as the target, because PHP typically merges to the oldest supported branch first. I agree, that using OpenSSL 4 should be mostly relevant for 8.6 and 8.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to detect missing SSLv3 support by checking OPENSSL_NO_SSL3 fails since OpenSSL 4, so the code assumes SSLv3 is available, but it is not.
As a consequence, several unit tests expection sslv3 streams to fail actually pass, despite no sslv3 support.