Skip to content

OpenSSL 4.x dropped the macro OPENSSL_NO_SSL3 - #24352

Open
rainerjung wants to merge 1 commit into
php:PHP-8.2from
rainerjung:OPENSSL_v_4-dropped_macro_OPENSSL_NO_SSL3
Open

rainerjung wants to merge 1 commit into
php:PHP-8.2from
rainerjung:OPENSSL_v_4-dropped_macro_OPENSSL_NO_SSL3

Conversation

@rainerjung

Copy link
Copy Markdown

Trying to detect missing SSLv3 support by checking OPENSSL_NO_SSL3 fails since OpenSSL 4, so the code assumes SSLv3 is available, but it is not.

As a consequence, several unit tests expection sslv3 streams to fail actually pass, despite no sslv3 support.

Trying to detect missing SSLv3 support by checking OPENSSL_NO_SSL3 fails since OpenSSL 4, so the code assumes SSLv3 is available, but it is not.
@rainerjung

Copy link
Copy Markdown
Author

The failing test doesn't have to do with this PR. It seems the FreeBSD test system is not available?

@devnexen

Copy link
Copy Markdown
Member

@ramsey @saundefined is it a worthy backport ?

@rainerjung

Copy link
Copy Markdown
Author

I only set 8.2 as the target, because PHP typically merges to the oldest supported branch first. I agree, that using OpenSSL 4 should be mostly relevant for 8.6 and 8.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants