From 5db8b8bc652e39265532ee284a1605f46016d1f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=B2=88=E6=98=B1=E6=88=90?= <300126469+yuchengshen931122-creator@users.noreply.github.com> Date: Sat, 21 Nov 2026 18:56:57 +0800 Subject: [PATCH] fix(email): accept exactly one pair of brackets around address literals `lstrip("[")`/`rstrip("]")` removed any number of brackets, so `user@[[192.168.0.1]]` and even `user@[[192.168.0.1]` were valid with `ipv4_address=True`. RFC 5321 4.1.3 allows exactly one pair. Co-Authored-By: Claude Opus 5.5 --- src/validators/email.py | 2 +- tests/test_email.py | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/validators/email.py b/src/validators/email.py index 46cc5946..d909563f 100644 --- a/src/validators/email.py +++ b/src/validators/email.py @@ -67,7 +67,7 @@ def email( if ipv6_address or ipv4_address: if domain_part.startswith("[") and domain_part.endswith("]"): # ref: RFC 5321 - domain_part = domain_part.lstrip("[").rstrip("]") + domain_part = domain_part[1:-1] else: return False diff --git a/tests/test_email.py b/tests/test_email.py index 9b82eb46..32df011b 100644 --- a/tests/test_email.py +++ b/tests/test_email.py @@ -72,3 +72,20 @@ def test_rejects_newline_after_local_part(local_part: str): def test_returns_failed_validation_on_idna_mapped_lookalike_domain(domain_part: str): """Test returns failed validation on email domains that only IDNA 2003 mapping makes valid.""" assert isinstance(email(f"user@{domain_part}"), ValidationError) + + +@pytest.mark.parametrize( + ("value", "flag"), + [ + ("user@[[192.168.0.1]]", "ipv4_address"), + ("user@[[192.168.0.1]", "ipv4_address"), + ("user@[192.168.0.1]]", "ipv4_address"), + ("user@[[[2001:db8::1]]]", "ipv6_address"), + ], +) +def test_rejects_extra_brackets_around_address_literal(value: str, flag: str): + """Test an address literal has exactly one pair of brackets (RFC 5321 4.1.3).""" + assert isinstance(email(value, **{flag: True}), ValidationError) + assert email( + f"user@[{'192.168.0.1' if flag == 'ipv4_address' else '2001:db8::1'}]", **{flag: True} + )