From 4f47fdd16791a94aad2289da3b0b19ec15802cb4 Mon Sep 17 00:00:00 2001 From: Kayvan Zahiri <123409429+Kayvan-Zahiri@users.noreply.github.com> Date: Sun, 25 Oct 2026 11:34:20 -0700 Subject: [PATCH] fix: update cached impression timestamps after repeated evaluations --- splitio/engine/cache/lru.py | 2 ++ tests/engine/cache/test_lru_updates.py | 42 ++++++++++++++++++++++++++ tests/engine/test_impressions.py | 16 +++++----- 3 files changed, 52 insertions(+), 8 deletions(-) create mode 100644 tests/engine/cache/test_lru_updates.py diff --git a/splitio/engine/cache/lru.py b/splitio/engine/cache/lru.py index 2f720a35..b7255736 100644 --- a/splitio/engine/cache/lru.py +++ b/splitio/engine/cache/lru.py @@ -60,6 +60,8 @@ def test_and_set(self, key, value): to_return = node.value if node else None if node is None: node = SimpleLruCache._Node(key, value, None, None) + else: + node.value = value node = self._bubble_up(node) self._data[key] = node self._rollover() diff --git a/tests/engine/cache/test_lru_updates.py b/tests/engine/cache/test_lru_updates.py new file mode 100644 index 00000000..76f631db --- /dev/null +++ b/tests/engine/cache/test_lru_updates.py @@ -0,0 +1,42 @@ +"""Regression coverage for replacing cached impression timestamps.""" +from splitio.engine.cache.lru import SimpleLruCache +from splitio.engine.impressions.manager import Observer +from splitio.models.impressions import Impression + + +class LruUpdateTests(object): + def test_repeated_updates_return_latest_value(self): + cache = SimpleLruCache(2) + assert cache.test_and_set('key', 1) is None + assert cache.test_and_set('key', 2) == 1 + assert cache.test_and_set('key', 3) == 2 + + def test_update_promotes_and_replaces_lru(self): + cache = SimpleLruCache(2) + cache.test_and_set('a', 1) + cache.test_and_set('b', 2) + assert cache.test_and_set('a', 3) == 1 + cache.test_and_set('c', 4) + assert cache.test_and_set('a', 5) == 3 + assert cache.test_and_set('b', 6) is None + + def test_observer_reports_immediately_previous_time(self): + observer = Observer(2) + def impression(timestamp): + return Impression('key', 'flag', 'on', 'rule', 1, None, timestamp, None, None) + assert observer.test_and_set(impression(100)).previous_time is None + assert observer.test_and_set(impression(200)).previous_time == 100 + assert observer.test_and_set(impression(300)).previous_time == 200 + + def test_optimized_strategy_deduplicates_after_hour_boundary(self, mocker): + from splitio.engine.impressions.strategies import StrategyOptimizedMode + mocker.patch('splitio.engine.impressions.strategies.utctime_ms', return_value=3600200) + strategy = StrategyOptimizedMode() + def impression(timestamp): + return Impression('key', 'flag', 'on', 'rule', 1, None, timestamp, None, None) + stored, _, _, _ = strategy.process_impressions([(impression(1000), None)]) + assert len(stored) == 1 + stored, _, _, _ = strategy.process_impressions([(impression(3600100), None)]) + assert len(stored) == 1 + stored, _, _, _ = strategy.process_impressions([(impression(3600200), None)]) + assert stored == [] diff --git a/tests/engine/test_impressions.py b/tests/engine/test_impressions.py index 715bfe1b..290c8890 100644 --- a/tests/engine/test_impressions.py +++ b/tests/engine/test_impressions.py @@ -147,13 +147,13 @@ def test_standalone_optimized(self, mocker): (ImpressionDecorated(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, None, None), False), None), (ImpressionDecorated(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, None, None), False), None) ]) - assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), + assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)] assert deduped == 0 assert for_unique_keys_tracker == [] assert len(manager._strategy._observer._cache._data) == 3 # distinct impressions seen - assert for_counter == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), + assert for_counter == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)] # Test counting only from the second impression @@ -221,7 +221,7 @@ def test_standalone_debug(self, mocker): (ImpressionDecorated(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, None, None), False), None), (ImpressionDecorated(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, None, None), False), None) ]) - assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), + assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)] assert for_counter == [] assert for_unique_keys_tracker == [] @@ -340,17 +340,17 @@ def test_standalone_optimized_listener(self, mocker): (ImpressionDecorated(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, None, None), False), None), (ImpressionDecorated(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, None, None), False), None) ]) - assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), + assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)] assert deduped == 0 assert listen == [ - (Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), None), + (Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), None), (Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None), None), ] assert for_unique_keys_tracker == [] assert len(manager._strategy._observer._cache._data) == 3 # distinct impressions seen assert for_counter == [ - Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), + Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None) ] @@ -425,10 +425,10 @@ def test_standalone_debug_listener(self, mocker): (ImpressionDecorated(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, None, None), False), None), (ImpressionDecorated(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, None, None), False), None) ]) - assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), + assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)] assert listen == [ - (Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), None), + (Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), None), (Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None), None) ] assert len(manager._strategy._observer._cache._data) == 3 # distinct impressions seen