From ea3c959daf46d93e2056c9fe8c1338716a353914 Mon Sep 17 00:00:00 2001 From: Phil Nash Date: Wed, 7 Nov 2012 16:31:41 +0000 Subject: [PATCH] Stops clean_old_versions from removing finished experiments which have reset => false --- lib/split/helper.rb | 3 ++- spec/helper_spec.rb | 9 +++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/split/helper.rb b/lib/split/helper.rb index 4a290640..44ae7a23 100644 --- a/lib/split/helper.rb +++ b/lib/split/helper.rb @@ -78,7 +78,8 @@ def clean_old_versions(experiment) def old_versions(experiment) if experiment.version > 0 - ab_user.keys.select { |k| k.match(Regexp.new(experiment.name)) }.reject { |k| k == experiment.key } + ab_user.keys.select { |k| k.match(Regexp.new(experiment.name)) }. + reject { |k| k.match(Regexp.new("^#{experiment.key}(:finished)?$")) } else [] end diff --git a/spec/helper_spec.rb b/spec/helper_spec.rb index 5f6f7ae5..03502c22 100755 --- a/spec/helper_spec.rb +++ b/spec/helper_spec.rb @@ -109,6 +109,15 @@ button_size_alt = Split::Alternative.new(button_size, 'button_size') button_size_alt.participant_count.should eql(1) end + + it "should not over-write a finished key when an experiment is on a later version" do + experiment = Split::Experiment.find_or_create('link_color', 'blue', 'red') + experiment.increment_version + session[:split] = { experiment.key => 'blue', experiment.finished_key => true } + finshed_session = session[:split].dup + ab_test('link_color', 'blue', 'red') + session[:split].should eql(finshed_session) + end end describe 'finished' do