Repository navigation
Fix FP32 log IEEE-754 handling in NEON and SVE - #1326
harshith-roy wants to merge 2 commits into
Conversation
Signed-off-by: Jenkins <bsgcomp@arm.com>
Independent validation on physical Apple Silicon (NEON)Thanks for the upstream fix, @harshith-roy. I tested PR #1326 on a physical Apple M5 (macOS 27.2, Apple clang 21.0.0), comparing the unmodified v53.3.1 implementation ( Correctness
Performance — FP32 Log, 1M elements
The patch restores correctness in the tested cases, but the performance regression is significant, particularly for the single-threaded workload. It would be worth investigating whether the special-value handling can be optimized further before merging. Two review findings
Scope: All execution testing was native NEON on Apple Silicon. SVE was not executed on physical hardware. Overall, I can confirm the reported NEON correctness improvement on physical hardware, with the performance regression and Darwin test portability issue noted above. Thanks again for working on this upstream! |
Summary
This change improves IEEE-754 exceptional-value handling and subnormal accuracy in the NEON and SVE FP32 logarithm implementations.
It also fixes an FP16 SOFT_RELU overflow regression exposed by the corrected logarithm behavior.
Changes
Validation
Validated using AArch64 cross-compilation and QEMU user-mode emulation.
Both NEON and SVE builds passed with warnings treated as errors.
Note: Runtime validation was performed under QEMU, not physical ARM hardware.