Repository navigation
arm64: dts: apple: Add PCIe nodes for t6031 - #504
Conversation
0731d14 to
85c8c3e
Compare
| #iommu-cells = <1>; | ||
| interrupt-parent = <&aic>; | ||
| interrupts = <AIC_IRQ 0 1492 IRQ_TYPE_LEVEL_HIGH>; | ||
| power-domains = <&ps_apcie_sys_gp>; |
There was a problem hiding this comment.
should have 4 pm domains, right?
There was a problem hiding this comment.
I'm not sure? ps_apcie_sys_gp depends on ps_apcie_gp, ps_afnc3_lw0, ps_afnc3_ls, ps_afnc3_ioa (transitively).
There was a problem hiding this comment.
if i am reading the adt right, it also wants ps_apcie_sys_ge, ps_apcie_sys_st, and ps_apcie_sys_st1
There was a problem hiding this comment.
I'm not convinced that ps_apcie_sys_st and ps_apcie_sys_st1 are needed. nvme power-states also has dependencies on apcie_*{ge,gp} but worked without them. ps_apcie_sys_ge is missing
a42322e to
56aa271
Compare
fbbc940 to
c2d55b6
Compare
| */ | ||
| &port00 { | ||
| bus-range = <1 1>; | ||
| pwren-gpios = <&smc_gpio 19 GPIO_ACTIVE_HIGH>; |
There was a problem hiding this comment.
pwren-gpios need top be in a separate commit as that's not upstreamable. Adding the pcie ports to the device .dts is also easier to manage as separate commit.
|
partially merged to asahi-wip. I added |
37c4a7e to
47a392c
Compare
Signed-off-by: Yureka <yuka@yuka.dev>
Signed-off-by: Yureka <yuka@yuka.dev>
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
The DCP's RTKit takes a keep-awake reference at boot (apple,rtkit-keep-awake): without one its firmware hibernates at its first idle and loses the doorbells that follow. Held for good, it keeps the firmware from napping. macOS holds its DCP for 60 s after boot (AppleDCPExpert's _bootCompleteTimeoutGated), then lets it nap whenever idle. Drop the reference nap_after_s (default 60, 0 keeps it) after dcp_start, and take it again before the unbind's shutdown, so that runs as before. The debugfs keep_awake knob shares the toggle and its lock (now per DCP). It needs DISP_CPU's floor at 0 and its power-gate retention on (the PMGR's apple,pwrgate): with the retention off, the first call after the drop was sent and never answered (AsahiLinux#503: swap_start with no reply, flip_done timed out, "unexpected busy command channel", the display lost until a reboot). With it on, the napping firmware leaves DISP_CPU power-gated 98-100 % of each idle window and answers every call (r174, six alternated pairs at runtime; AsahiLinux#504, napcheck.sh: after the boot's nap 20 backlight steps, 10 DPMS cycles, a session restart and 10 s2idle cycles with no DCP error, DISP_CPU gated 99.2-99.8 % at the idle desktop).
Uh oh!
There was an error while loading. Please reload this page.