Repository navigation
fix: Ensure search histogram count matches result table count - #2256
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: bfa2dbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
|
<!-- claude-code-review --> PR Review✅ No critical issues found. A few minor observations (non-blocking):
|
E2E Test Results✅ All tests passed • 169 passed • 3 skipped • 1203s
Tests ran across 4 shards in parallel. |
Deep Review🟡 P2 -- recommended
🔵 P3 nitpicks (10)
Reviewers (9): correctness, testing, maintainability, project-standards, agent-native, learnings-researcher, performance, adversarial, kieran-typescript. Testing gaps:
|
82baef4 to
ea38aba
Compare
ea38aba to
b8c2616
Compare
PR Review
Notes (non-blocking):
|
Ah interesting, yeah that appears to be a broader bug where stacked bar charts with a single bucket don't render correctly - you can see in the tooltip that the chart is actually getting the correct data, just not displaying it.
Same happens on chart explorer:
Happy to look at that too as a separate issue but I think #2255 was specifically about the counts not matching. |




Summary
This PR updates the ChartConfig used for the search page histogram and total result count, so that the count always matches what is shown in the results table.
Previously, there were two reasons the count might not match:
Screenshots or video
Before: alignment resulted in a count that was greater than the number of results in the table
After: Count is correct even when date range is not aligned or exactly matches the queried result's timestamp (due to end inclusivity)
How to test on Vercel preview
This can be tested in the preview environment by playing around with the filters and time ranges to get a small (countable) number of results. Or locally by seeding clickhouse with some data at particular timestamps (which is what the new E2E test does)
References