Repository navigation
ci: add report-only Trivy, govulncheck and yarn npm audit scans - #3735
jordan-simonovski wants to merge 2 commits into
Conversation
Image, Go and npm vulnerability findings now show up in each run's job summary and, from main and the daily schedule, in the GitHub Security tab. Nothing fails a build on findings yet, because main already has some.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
| security-events: write | ||
| defaults: | ||
| run: | ||
| working-directory: packages/otel-collector |
There was a problem hiding this comment.
🟡 P2 — Bumping Go in the Dockerfile doesn't trigger govulncheck on the PR
govulncheck takes its Go version from docker/otel-collector/Dockerfile, but that file isn't in the pull_request path filter. A PR that changes only the golang base image (a toolchain bump that changes stdlib advisories) gets no Dependency Scan run. The change only shows up after merge or on the daily schedule. Add docker/otel-collector/Dockerfile to paths.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
There was a problem hiding this comment.
Fixed in 0416abe: docker/otel-collector/Dockerfile is now in the path filter, and the version step fails with an error if it can't parse the Go version.
PR Review✅ No issues found. |
Deep Review✅ No critical issues found. This is a report-only CI change (composite Trivy action + new dependency-scan workflow + scan steps wired into 🟡 P2 — recommended
🔵 P3 nitpicks (3)
Reviewers (8): correctness, security, reliability, adversarial, maintainability, testing, project-standards, previous-comments. Testing gaps: No fixture exercises the No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 470 passed • 1 skipped • 1117s
Tests ran across 4 shards in parallel. |
Its Go version now comes from the collector Dockerfile, so a PR that bumps it re-runs the scan, and a FROM line the parse can't read fails with a clear error instead of scanning against the runner's Go.
Summary
CI now reports known vulnerabilities in our Docker images, the collector's Go code and our npm dependencies, using free tools only. Findings appear in each run's job summary, and runs on main and the daily schedule also send them to the Security tab. Nothing fails a build on findings yet, because main already has some to work through.
docker-build.ymlbuilds them.yarn npm auditcovers production dependencies in every workspace, plus all of@hyperdx/cli, which bundles its devDependencies into the release.Key decisions
.vex/openssl-mongodb.vex.json. Its statements name the Docker Scout product, which Trivy can't match on a locally built image, so it suppressed nothing.tj-actions/changed-filesindocker-build.ymlis now pinned by SHA, because those jobs now holdsecurity-events: write. The new trivy-action and upload-sarif steps are pinned the same way.How to reproduce
On this branch:
Implementation detail
.github/actions/trivy-scanand run withcontinue-on-errorand a 10 minute timeout, so a Trivy DB outage can't fail or stall an image build.load: trueis now set on the collector and app builds so Trivy can read the image from the local daemon.cmd/migrateonly. Trivy covers the OCB-built collector binary by matching the Go modules embedded in it.2-nightlyimages, and ran actionlint and zizmor on the workflows.