Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 3f85609 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
1 finding(s): 🔴 0 P0/P1 · 🟡 0 P2 · 🔵 1 P3 No inline comments. 1 P3 folded at the bottom. 🔵 1 P3 — no action needed before merge
Priority comes from a separate grading pass over the finished review. P3 is folded here instead of posted inline. No finding blocks merge automatically; a maintainer decides. |
Deep Review✅ No critical issues found. This is a focused, well-tested bug fix. The core behavioral change — defaulting the preview table's sort to 🔵 P3 nitpicks (2)
Reviewers (8): correctness, testing, maintainability, kieran-typescript, julik-frontend-races, project-standards, learnings-researcher, previous-comments. Testing gaps: Helper functions, the uncontrolled clear-sort behavior, and the end-to-end edit-Order-By flow are all covered (unit + component + e2e); the only untested seam is the No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 469 passed • 1 skipped • 1148s
Tests ran across 4 shards in parallel. |
d46562b to
2ae4268
Compare
2ae4268 to
963be99
Compare
963be99 to
5bac70d
Compare
5bac70d to
3f85609
Compare
Summary
Issue
In the chart explorer, Table display type:
aliased duration min, which sorts as unquoted duration min ASC). The
query errors.
header click.
Fix
Screenshots or video
Before
Screen.Recording.2026-11-20.at.2.49.41.PM.mov
After
Screen.Recording.2026-11-20.at.2.51.16.PM.mov
How to test on Vercel preview
Take the steps depicted in the attached videos.
References