Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: fac5298 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
E2E Test Results✅ All tests passed • 473 passed • 1 skipped • 1259s
Tests ran across 4 shards in parallel. |
Contributor
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
…n/skip-column-refetch-heatmap-filters
…n/skip-column-refetch-heatmap-filters
…n/skip-column-refetch-heatmap-filters
…n/skip-column-refetch-heatmap-filters # Conflicts: # packages/app/src/DBSearchPage.tsx
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #3749. That PR stops the search histogram refetching when a table column is added or removed. Two other search page queries were built from the same config and still refetched:
WITHclause. Adding an aliased column, or the alias map reloading after any column change, changed its query.selectand every alias. The filter queries set their own select, so neither affects their SQL; they only changed the query key.Both now take the same
referencedAliasWithas the histogram (only aliases the where, filters or group by use), and the filter config drops the tableselect.Screenshots or video
No visual change; this removes a loading flash. I couldn't capture screenshots here — @aaronknudtson to add a before/after video if wanted.
How to reproduce
Starting point:
yarn app:dev:localconnected to the demo server.On
main:On this branch:
How to test on Vercel preview
Preview routes: /search
Steps:
References