Repository navigation
Accept NULL strides in DLPack tensors on oneAPI devices - #3183
Draft
antonwolfy wants to merge 5 commits into
Draft
antonwolfy wants to merge 5 commits into
antonwolfy wants to merge 5 commits into
Conversation
The `Run tests with oneMath develop branch` jobs build dpnp against the head of oneMath `develop`. A failure there comes from upstream, not from the PR under test, while the two jobs take 39-68 min each, about 105 min of runner time per push (median of the last 6 `master` runs). This PR moves them off pushes and PRs: - `check-onemath.yaml` gets a nightly `schedule` (03:17 UTC) and a `workflow_dispatch` trigger. - `test_by_branch` runs only on `schedule` and `workflow_dispatch`. `test_by_tag` keeps running on pushes and PRs, and is skipped on the nightly run. - The oneMath checkout uses the renamed `uxlfoundation/oneMath` repository instead of the `oneapi-src/oneMKL` redirect (its default branch is still `develop`), and the step names and the source directory variable say oneMath. Neither job is a required check. A failed nightly run shows in the Actions tab, and GitHub sends its notification to the user who last changed the `cron` line. On this PR the develop branch jobs show as skipped; the first nightly run after merge, or a manual dispatch, is the real check.
…mpiler (#3174) DPC++ 2026.0 is the minimum compiler (the conda recipes reject anything older), and every 2026.x release ships libsycl 9 (`__LIBSYCL_MAJOR_VERSION 9`). Two `__LIBSYCL_MAJOR_VERSION` checks in the libtensor headers therefore always take the same branch. This PR: - drops the `__LIBSYCL_MAJOR_VERSION < 7` term from `needs_workaround` in `kernels/reductions.hpp`, which kept `sycl::logical_or<bool>` off reduce-over-group for older compilers. The term is always false; the `int64`/`uint64` `sycl::multiplies` exclusion stays. - removes `USE_GROUP_LOAD_STORE` from `utils/sycl_utils.hpp`, so `sub_group_load` and `sub_group_store` always use `group_load`/`group_store` from `sycl_ext_oneapi_group_load_store`. The `__LIBSYCL_MAJOR_VERSION >= 8u` check already set the macro to 1 (DPC++ 2026.0 doesn't define the `SYCL_EXT_ONEAPI_GROUP_LOAD_STORE` feature-test macro the check looked at first). Setting it to 0 by hand doesn't work either: the fallback calls the `sycl::sub_group` member `load`/`store`, and icpx 2026.0 fails with `no member named 'load' in 'sycl::sub_group'`. The macro is defined in a header shipped with dpnp, hence the changelog entry. The default build compiles the same code as before. With icpx 2026.2, a syntax-only compile of both headers passes without warnings, and static asserts confirm that `needs_workaround` and `can_use_reduce_over_group` keep their values for `logical_or<bool>` and for the `int64`/`uint64` `multiplies`.
`from_dlpack_capsule` read `strides[i]` of a `kDLOneAPI` tensor without checking for NULL to find the extent of its memory, so importing a tensor with NULL strides segfaulted. Before DLPack 1.2, NULL strides mean the tensor is C-contiguous, and the `kDLCPU` branch already handled them. The extent is now computed from C-contiguous strides when `strides` is NULL.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
November 9, 2026 12:10
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the DLPack NULL-stride fix and related maintenance updates.
No open issues 🎉
What changed in this PR
Fixes a crash in dpnp’s DLPack imports when a oneAPI tensor uses NULL strides to represent C-contiguous data, as allowed before DLPack 1.2. Regression tests build on the ctypes helper from #3181.
Changes:
- Computes the memory extent using implicit C-contiguous strides and tests legacy and versioned capsules across several shapes.
- Removes legacy SYCL load/store fallbacks and an older compiler workaround.
- Moves oneMath develop-branch checks to nightly/manual runs and updates the upstream repository reference.
| File | Description |
|---|---|
dpnp/tests/tensor/test_usm_ndarray_dlpack.py |
Adds NULL-stride import regression tests, including empty arrays. |
dpnp/tensor/_dlpack.pyx |
Handles NULL strides when calculating oneAPI tensor memory extent. |
dpnp/libtensor/include/utils/sycl_utils.hpp |
Uses the group load/store extension unconditionally. |
dpnp/libtensor/include/kernels/reductions.hpp |
Removes the pre-SYCL-7 Boolean reduction workaround. |
CHANGELOG.md |
Records the DLPack fix and load/store fallback removal. |
.github/workflows/check-onemath.yaml |
Schedules develop-branch checks and switches to uxlfoundation/oneMath. |
Review effort: Balanced
Contributor
|
Array API standard conformance tests for dpnp=0.22.0dev1=np2py314h8d9cdd5_11 ran successfully. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a segfault in
dpnp.tensor.from_dlpackanddpnp.from_dlpackwhen importing a DLPack tensor on a oneAPI device with NULL strides.To find the extent of the memory a
kDLOneAPItensor views,from_dlpack_capsulereadstrides[i]for every dimension without checking for NULL. DLPack before v1.2 allowsstridesto be NULL to mean a C-contiguous tensor, and thekDLCPUbranch already handles that. The extent is now computed from C-contiguous strides whenstridesis NULL. The resulting array was already built with C-contiguous strides in that case.dpnp's own capsules always set strides, so only tensors from other producers, through a legacy
DLManagedTensoror a versioned tensor older than 1.2, reach this.The test builds such tensors with the
_dlpack_ctypeshelper added in #3181, so this PR is stacked on #3181 and targets its branch; it is to be retargeted tomasteronce #3181 is merged. Without the fix, every case of the new test segfaults, and computing the extent with a stride of 1 instead of the C-contiguous strides fails the 2-D case. The DLPack tests indpnp/tests/tensor/test_usm_ndarray_dlpack.pyanddpnp/tests/test_dlpack.pypass on a Level Zero iGPU and the OpenCL CPU device.