Repository navigation
fix: remove \n and \r exclusion from quoted identifiers - #2936
Open
harryfoster2006 wants to merge 3 commits into
Open
harryfoster2006 wants to merge 3 commits into
harryfoster2006 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoted identifiers that contain a line break failed to parse. For example, a column name copied from a spreadsheet or BI tool, such as "A/\nB", produced a ParseException. The S_QUOTED_IDENTIFIER token explicitly excluded \n and \r from the body of every quoting style.
Fix
Remove the \n / \r exclusion from S_QUOTED_IDENTIFIER in JSqlParserCC.jjt for all four forms:
...(backtick)The identifier text is kept verbatim, so the newline survives a parse and deparse round trip unchanged.