Repository navigation
Conversation
|
I would refuse to start. Like driving on a bald tire ( mandatory car ananlogy) and protect the user from themselves. |
Sure - the less interrupting scenario here is that we could set the transaction isolation level ourselves, but such changes are highly affecting. If we include a "do it anyway", I could get on board with that. I question making such a big change without the administrator being involved. Channels could be relying upon repeatable read for correctness. |
maybe for fresh installs do a hard stop? |
That could work. Sure. Updated. |
NicoPiel
left a comment
There was a problem hiding this comment.
The check doesn’t match its message. Both checks only reject REPEATABLE_READ, but the messages say READ-COMMITTED is required. SERIALIZABLE, which locks even more, gets through with no block and no warning. The fix is to test for “not READ_COMMITTED” instead.
This is intentional, but I'm open to other phrasing of the message. A DBA may reasonably configure the system away from |
tonygermano
left a comment
There was a problem hiding this comment.
A few minor things suggested inline, but, otherwise, looks good to me. Those were supposed to be part of the same review, but I guess I clicked the wrong button.
Could you also please create the release note and put it in the PR description?
2c1271f to
de18cb3
Compare
|
@NicoPiel, I changed the phrasing of the message. |
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
de18cb3 to
89f9c24
Compare
|
@mgaffigan I squashed the 3rd commit into the first (my inline suggestions that you applied), but there is a merge conflict on rebase that I'll let you handle since it will dismiss the reviews when it's force pushed. |
tonygermano
left a comment
There was a problem hiding this comment.
Not approved yet. The approach is good, but one item should be settled before merge.
- MariaDB is used by many OIE users, and MariaDB 10.11 (still supported) rejects
transaction_isolationas a session variable (ERROR 1193: Unknown system variable 'transaction_isolation'); it only acceptstx_isolation. The URL inmirth.propertieswould make the connection fail at startup there. 11.4 and 11.8 accept both. Please add thetx_isolationvariant for MariaDB 10.11 to themirth.propertiescomment and the release note. - (non-blocking) Nit: trailing whitespace in
MysqlDaoFactory(the"...transaction "string line and the blank line before thetryincheckTransactionIsolation). - (non-blocking) Nit: a unit test for
checkNewDatabase(mockedConnectionreturningTRANSACTION_REPEATABLE_READthrowsDonkeyDaoException,READ_COMMITTEDdoesn't) would be nice, as a follow-up.
Notes for the maintainers (no action needed from the author):
- The branch conflicts with the DAL refactoring on main in
JdbcDaoFactory.java. On rebase, keep main's newgetDaosignature (noPreparedStatementSource) and addcheckNewDatabaseabove it. Claude checked that this resolution compiles. - Claude checked
SET SESSION transaction_isolation='READ-COMMITTED'andSET SESSION tx_isolation='READ-COMMITTED'against mariadb 10.11.19, 11.4.13 and 11.8.9 using the server's own client (the JDBC URL parameter itself was not exercised).
🤖 Drafted with Claude Code
Running MySQL at the default REPEATABLE_READ transaction isolation level causes hangs and errors throughout the application when running at load. These were frequently the cause of flaky tests in #449, and have issues open in the nextgen repo.
Add a warning to startup to check for misconfigured instances, and update the instructions in mirth.properties to have the correct transaction isolation level.
Release note: