Repository navigation
Conversation
pacmano1
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
mgaffigan and
ssrowe
November 17, 2026 18:25
testExecuteGetRequest fetched https://www.nextgen.com, which sent the build machine's address and headers to an outside site on every test run, and failed offline or whenever the site was slow. It now starts an HTTPS server on 127.0.0.1 with a throwaway self-signed certificate for that address, so hostname verification stays on, and checks the body that comes back. The failure case uses a local port with nothing listening instead of a made-up domain, so the test makes no outside call, DNS included. Fixes OpenIntegrationEngine#313 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Finnegan's Owner <44065187+pacmano1@users.noreply.github.com>
pacmano1
force-pushed
the
httputil-test-oie-site
branch
from
November 17, 2026 19:05
cd25fb9 to
24564eb
Compare
mgaffigan
approved these changes
Nov 18, 2026
jonbartels
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #313.
HttpUtilTest.testExecuteGetRequestfetched https://www.nextgen.com, which sent the build machine's address and headers to an outside site on every test run, and failed offline or whenever the site was slow (SocketTimeoutException: Read timed outin local builds).It now starts an HTTPS server on 127.0.0.1 (the JDK's
HttpsServer) with a throwaway self-signed certificate for that address (BouncyCastle, already a dependency), so hostname verification stays on, and checks the body that comes back. The failure case uses a local port with nothing listening instead of a made-up domain, so the test makes no outside call, DNS included.How to verify
./gradlew :server:test --tests com.mirth.connect.util.HttpUtilTestpasses with no network. I ran it in a network namespace with only loopback up.Tested
./gradlew clean build: 917 tests, 0 failures.SSLPeerUnverifiedException, so it does go through TLS hostname verification.Co-authored with Claude Code.