Repository navigation
Conversation
…ine of code Resolves Pathoschild#135
This fixes a few edge cases: - downloads finishing without a guaranteed 100% progress update; - progress reporting invalid percentages (e.g. 250%) if the server provides an incorrect Content-Length; - progress never reported if the server provides no Content-Length; - a DivideByZeroException if the server provides a zero Content-Length.
This applies our pre-existing fixes like Pathoschild#126 to the new code.
We reported progress on every chunk read, but that could lead to a large number of callbacks when downloading a large file over a fast connection (e.g. thousands per second). The progress reports are now throttled to one per 250ms at most.
Owner
|
This looks good overall; thanks for the PR! There's one edge case I'm not sure how we should handle: when used with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download a resource, save it locally and report progress as data is being downloaded.
Resolves #135