Repository navigation
rust: alloc: reject offline NUMA nodes in allocator - #1270
Open
Franklin-Qi wants to merge 1 commit into
Open
Franklin-Qi wants to merge 1 commit into
Franklin-Qi wants to merge 1 commit into
Conversation
NumaNode::new() only checks that the id is in [0, MAX_NUMNODES). Safe Allocator APIs can still forward an offline node into k[v]realloc_node_align(), which may dereference NODE_DATA(nid) == NULL and panic (GPF). Reject offline nodes at the shared ReallocFunc boundary for nonzero allocations. Leave NUMA_NO_NODE and zero-sized free/realloc paths unchanged. A residual hotplug TOCTOU remains if a node goes offline after the check; this matches practical C usage for rejecting statically missing nodes from safe Rust. Fixes: 7760b64 ("rust: add support for NUMA ids in allocations") Cc: stable@vger.kernel.org Reported-by: Georgios Androutsopoulos <georgeandrout13@gmail.com> Closes: Rust-for-Linux#1263 Signed-off-by: Franklin-Qi <yusq77@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumaNode::new() only checks that the id is in [0, MAX_NUMNODES). Safe Allocator APIs can still forward an offline node into k[v]realloc_node_align(), which may dereference NODE_DATA(nid) == NULL and panic (GPF).
Reject offline nodes at the shared ReallocFunc boundary for nonzero allocations. Leave NUMA_NO_NODE and zero-sized free/realloc paths unchanged. A residual hotplug TOCTOU remains if a node goes offline after the check; this matches practical C usage for rejecting statically missing nodes from safe Rust.
Fixes: 7760b64 ("rust: add support for NUMA ids in allocations")
Cc: stable@vger.kernel.org
Reported-by: Georgios Androutsopoulos georgeandrout13@gmail.com
Closes: #1263
Signed-off-by: Franklin-Qi yusq77@gmail.com
Kernel Patch URL: https://lore.kernel.org/rust-for-linux/20261120021633.12274-1-yusq77@gmail.com/