Repository navigation
fix: support multiple classes in drag state options - #2485
Open
xiaoyao-666-coder wants to merge 1 commit into
Open
xiaoyao-666-coder wants to merge 1 commit into
xiaoyao-666-coder wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing more than one class in a state option such as
chosenClass: 'bg-blue-100 opacity-50'throwsInvalidCharacterErrorwhen dragging starts becausetoggleClasspasses the whole string toDOMTokenList.add.Split class names on whitespace and add or remove each non-empty token individually. The fallback for elements without
classListalso handles the tokens separately and keeps repeated additions from creating duplicates. The shared helper coverschosenClass,ghostClass,dragClass, andfallbackClass.Fixes #2443.
Validation:
classList, and a real fallback drag with multiple classes on the item and clone, including cleanup after drop.npm run buildpasses, including ESM, UMD, and minification. Generated bundles are excluded from the PR as required by the contribution guidelines.TestCafe was run with
--hostname 127.0.0.1and a separate browser profile for the local environment. No test runner or dependency changes are included.AI assistance: Codex assisted with the implementation and regression tests; the results above were verified locally.