Repository navigation
Conversation
PrimeCheck only rejected 0, 1 and even numbers, and for a negative odd n the loop condition i * i <= n is false at once, so PrimeCheck(-3) and PrimeCheck(-1) were true. Reject everything below 2.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
- Coverage 85.91% 85.91% -0.01%
==========================================
Files 379 379
Lines 19778 19777 -1
Branches 3016 3014 -2
==========================================
- Hits 16993 16992 -1
Misses 2785 2785 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Maths/PrimeCheck.jsrejected only0,1and even numbers. For a negative oddnthe loop conditioni * i <= nis false from the start, soPrimeCheck(-1),PrimeCheck(-3)and every other negative odd number returnedtrue. The two special cases are replaced byn < 2.I added a test for negative numbers (it fails on
master). I also comparedPrimeCheckwith a trial-division reference for-3..299: after this change they agree.npx vitest run Maths/test/PrimeCheck.test.jsandnpx prettier --checkpass.Written with the help of Claude Code (Claude Sonnet 5.5).
Checklist:
Fixes: #{$ISSUE_NO}.