Repository navigation
Conversation
…vate to protected. This allows subclasses to reallocate the validity buffer independently of the struct elements. Previously, expanding the validity buffer required a full vector reallocation, which could cause an OversizedAllocationException if the child data vectors were already near their capacity.
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
|
What's the use case for subclassing StructVector? |
We have a helper class which wraps StructVector to provide more fine grained control. Maybe @selvaganesang can provide some more details. |
|
Provides a mechanism for independent reallocation of embedded vectors to prevent over-expansion of variable-width vectors when the parent struct vector is reallocated. This only mimics the similar concept from ListVector. |
|
I suppose, why can't the improvements themselves be upstreamed? |
|
@lriggs @selvaganesang please re-engage here. I'm enumerating all the goodies we have tried by fire in production in order to upstream them all. This is one of them. @selvaganesang what are the improvements? All on the consumer end? Or more changes in arrow-java? |
|
I will review and work on this one after 20.0.0 release |
What's Changed
Changes the access modifier of reallocValidityBuffer from package-private to protected.
This allows subclasses to reallocate the validity buffer independently of the struct elements. Previously, expanding the validity buffer required a full vector reallocation, which could cause an OversizedAllocationException if the child data vectors were already near their capacity.