Skip to content

GH-66: [JDBC] Add test for closing a connection with a catalog twice - #1503

Merged
jbonofre merged 1 commit into
apache:mainfrom
AbhishekPathania:gh-66-jdbc-idempotent-close
Nov 19, 2026
Merged

jbonofre merged 1 commit into
apache:mainfrom
AbhishekPathania:gh-66-jdbc-idempotent-close

Conversation

@AbhishekPathania

Copy link
Copy Markdown
Contributor

What's Changed

Adds a regression test for #66: closing a connection that was opened with a catalog twice no longer throws, and CloseSession reaches the server only once. The original failure is already fixed on main. #933 removed the duplicate ArrowFlightSqlClientHandler#close call, and the second CloseSession on the shut-down channel now fails with UNAVAILABLE, which #910 suppresses.

MockFlightSqlProducer now implements closeSession so the test can count the calls.

The test was drafted with an AI assistant (Claude). I reviewed it and checked that it passes on main.

Closes #66.

@github-actions

This comment has been minimized.

@AbhishekPathania
AbhishekPathania marked this pull request as draft November 18, 2026 14:15
@AbhishekPathania
AbhishekPathania marked this pull request as ready for review November 18, 2026 15:28
@lidavidm lidavidm added the chore PRs that make misc changes. label Nov 19, 2026
@github-actions github-actions Bot added this to the 20.0.0 milestone Nov 19, 2026
@AbhishekPathania
AbhishekPathania force-pushed the gh-66-jdbc-idempotent-close branch from 0d5c552 to ed0d38c Compare November 19, 2026 10:10
@AbhishekPathania
AbhishekPathania force-pushed the gh-66-jdbc-idempotent-close branch from ed0d38c to 026b736 Compare November 19, 2026 12:11

@jbonofre jbonofre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AbhishekPathania!

@jbonofre
jbonofre merged commit e5978d5 into apache:main Nov 19, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PRs that make misc changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] Invocation of close method from ArrowFlightConnection throws a SQLException when using catalog as parameter

3 participants