This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Centralize git operation side effects - #1230
Merged
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to centralize all of the side effects associated with git operations, such as error-handling, showing notifications, prompting, and setting progress state. Previously this logic resided in controllers and views which coupled the side effect to a particular piece of the UI. This refactor ensures that a "push" will do the same thing regardless of whether it's triggered from the
PushPullMenuViewor from the GitHub panel as part of creating a PR.The implementation includes the creation of an
ActionPipelinefor each git operation (push, pull, fetch, commit, checkout) followed by middleware registration for each side effect ('confirm-force-push', 'set-push-in-progress', etc). The pipelines are passed to theRepository, which executes the pipeline actions associated with each git operation.Relies on atom/atom#16294
Supersedes some of the work in #1138
TODO:
currentBranchto update)GithubPackage