Repository navigation
Conversation
…te to javascript: Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.60-pr.376.c2b0448Prefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.60-pr.376.c2b0448"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.60-pr.376.c2b0448"
}
}
Preview published to npm registry — try new features instantly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createClientnow keepsappBaseUrlonly when it parses to anhttp:orhttps:URL. Any other value becomes"", so login and logout URLs stay relative to the current origin.appBaseUrlis used to build every auth navigation target (redirectToLogin,loginWithProvider,logout,loginViaPopup), so a non-http(s) value should never reachwindow.location. Valid values pass through unchanged.sanitizeAppBaseUrlinutils/auth-utils.ts. It is not added to the public exports.client.ts.createAuthModuleis only created there, so this covers every auth sink.Testing
npm run lint: clean.npm test: type tests clean, 457 unit tests pass.test.eachinclient.test.jsfails on the three non-http(s) cases without the fix and passes with it.🤖 Generated with Claude Code