Repository navigation
Load the Media Library widget script from the CDN again - #1378
Open
gabrielcld2 wants to merge 2 commits into
Open
gabrielcld2 wants to merge 2 commits into
gabrielcld2 wants to merge 2 commits into
Conversation
The CDN now sends Access-Control-Allow-Origin, so the plugin loads the script from media-library.cloudinary.com again and the vendored copy is no longer used.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1254 and the 3.3.7 hotfix.
Approach
crossorigin="anonymous"to cross-origin scripts on block editor screens for Chromium 137+, and the CDN didn't send CORS headers, so the script was blocked.media-library.cloudinary.comnow returnsAccess-Control-Allow-Origin: *for its.jsfiles in production.Media::editor_assets()loads the script fromCLOUDINARY_ENDPOINTS_MEDIA_LIBRARYagain, so the plugin picks up widget updates without anyone copying files by hand.js/cloudinary-media-library.js, which nothing else uses. It was identical to the CDN version apart from the header comment.QA notes
curl -sI -H "Origin: https://example.com" https://media-library.cloudinary.com/global/all.js | grep -i access-controlreturnsaccess-control-allow-origin: *.all.jsloads frommedia-library.cloudinary.comwithcrossorigin="anonymous", there are no CORS errors in the console, and the widget renders.blocked by CORS policy: No 'Access-Control-Allow-Origin' header.