Repository navigation
ci: keep the Docker Hub OIDC token valid until the image push - #8150
Merged
Merged
Conversation
The Docker Hub token from docker/login-action's OIDC exchange lasts 300 seconds by default. The multi-arch build takes about 10 minutes and pushes at the end, so the v4.146.0 push failed with 401 incorrect username or password. Ask for an hour, as coder/coder's dogfood.yaml does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
code-asher
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dockerjob of Publish code-server for v4.146.0 logged in to Docker Hub with OIDC at 19:08:18 and pushed at 19:17:59. The push failed with:docker/login-actionv4.7.0 requests a Docker Hub token that lastsDOCKERHUB_OIDC_EXPIREINseconds, default 300 and maximum 21600. The multi-arch build pushes at the end, about 10 minutes in, so the token had expired. This asks for 3600, as coder/coder'sdogfood.yamlalready does.Note:
releaseonly acceptsv*tags, so publishing reruns the tag's copy ofpublish.yaml. A rerun for v4.146.0 would still use the 5-minute token. This takes effect from the next release.🤖 Generated with Claude Code