Repository navigation
Solution for ticket #3353 'Allow explicit undef's for configuration' - #65
Merged
Merged
Conversation
…for configuration' Signed-off-by: makulik <g-makulik@t-online.de>
Signed-off-by: makulik <g-makulik@t-online.de>
danmar
pushed a commit
that referenced
this pull request
Nov 30, 2011
Solution for ticket #3353 'Allow explicit undef's for configuration'
Collaborator
|
Thanks for all your trouble and work with this. I had a minor note only. |
Contributor
Author
|
De nada! As mentioned I'm also getting more experienced ;-) Anyway, the two todo testcases undef6 and undef7 leave me a bit dazzled. There's either some flaw in the implementation how the Preprocessor::getcode() expands #else (#elif) code pathes and macro definitions for the default configuration, or I didn't get how it works. To be honest, I have difficulties to understand how the matching_ifdef and matched_ifdef lists work in this method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testcases testpreprocessor.cpp 'undef6' and 'undef7' are still not working as expected, may be someone else can help here. For the background use case I have described in my ticket this solution should work fine though.
Looks all fine to me now! I created a completely new fork of the repo, don't know how to repair the old one :-(. Anyway I've learned some new techniques using GIT when trying to do so ...