Repository navigation
Conversation
Add a CI-buildtools workflow. It runs on the
ghcr.io/cppchecksolutions/buildtools-ubuntu-{22.04,24.04,26.04}:v3
images and runs testrunner, the extra tests, test/cli, test/cfg,
XML validation, the addons tests and test/tools.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dmcppcheck
reviewed
Nov 20, 2026
dmcppcheck
left a comment
Contributor
There was a problem hiding this comment.
AI review
I found no functional problems in the new workflow. It matches the steps in CI-unixish.yml, CI-unixish-docker.yml and scriptcheck.yml, and the packages it installs cover what those steps import or run. Three remarks:
- The 26.04 image is pinned to
:v1, but the PR description says:v3, like the other two images. One of them is wrong. - The
CMakeLists.txtchange has nothing to do with this workflow, which builds withmake. It only applies on CMake ≥ 4.5, so no CI job here runs it. - The workflow doesn't use ccache, unlike the other docker workflows. Each of the three images rebuilds everything from scratch on every PR.
There are no earlier comments to track.
Comments
| # | Comment | By | Where | Status |
|---|---|---|---|---|
| 1 | 26.04 image is pinned to :v1 but the PR description says :v3 | AI review | .github/workflows/cppchecksolutions-build.yml:27 |
🆕 New |
| 2 | No ccache: each of the 3 images does a full rebuild on every run | AI review | .github/workflows/cppchecksolutions-build.yml:51 |
🆕 New |
| 3 | Unrelated CMake change that no CI job in this PR exercises | AI review | CMakeLists.txt:7 |
🆕 New |
@danmar, please fix, resolve or reply to the open and new comments: #1, #2, #3.
Testing
- The PR changes no C++, Python or test sources:
diff -rq base prshows only the new workflow file andCMakeLists.txt. Because of that I didn't buildcppcheck/testrunneror write scratch inputs; it would only have tested base code. cmake -S . -B /tmp/b -Werror=devwith the PR'sCMakeLists.txtand CMake 3.28.3 configures cleanly (exit 0). The newif(CMAKE_VERSION VERSION_GREATER_EQUAL 4.5)block is skipped there, so I couldn't test thecmake_diagnostic(SET CMD_STRICT IGNORE RECURSE)call itself. No CMake ≥ 4.5 was available.- I checked by reading that the dependencies are covered:
- The Python imports used by test/cli, addons/test, test/tools (htmlreport uses pygments; reduce and donate_cpu need only the stdlib) are covered by the apt packages installed.
checkcfgskips its pkg-config- and xmlstarlet-dependent parts when those tools are missing.- The strace test in
test/cli/other_test.pyis covered by the strace package. - Using
-Werrorfor test/cli on 22.04 matches whatCI-unixish.ymlalready does on ubuntu-22.04.
- I couldn't run the workflow itself: there is no network access and none of the ghcr images are available.
Automated review of 870690c by Claude. The pull request was built and tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a CI-buildtools workflow. It runs on the
ghcr.io/cppchecksolutions/buildtools-ubuntu-{22.04,24.04,26.04} images and runs testrunner, the extra tests, test/cli, test/cfg, XML validation, the addons tests and test/tools.