Repository navigation
Conversation
This replaces the `packageRootUri` query parameter with `VmServiceUri` in `api/serveAvailableExtensions`. Before this change, the DevTools app requested the user's package root file path from the VM service, and passed it along to `api/serveAvailableExtensions` using the `packageRootUri` query parameter. This meant that an untrusted caller could pass any directory on the host fileystem to probe directories or serve extensions outside of the active project directory. This deprecates the `packageRootUri` query parameter and replaces it with `vmServiceUri`, which allows the DevTools server to validate `vmServiceUri` and resolve the package root in `VmServiceHandler.detectRootPackageForVmService`.
johnpryan
requested review from
a team,
bkonyi and
kenzieschmoll
as code owners
November 18, 2026 23:34
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the DevTools extension resolution mechanism to use the VM service URI instead of the client-provided package root file URI when querying and serving available extensions. This change includes updates to the ExtensionService, server-side handlers, and test targets to resolve the package root on the server. The review feedback highlights a placeholder PR link in the release notes that must be resolved, a potential null dereference on packageRootUriString in _vm_service.dart, and a recommendation to use p.posix.dirname instead of fragile manual substring arithmetic for resolving the package config path.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the
packageRootUriquery parameter withVmServiceUriin
api/serveAvailableExtensions.Before this change, the DevTools app requested the user's package root file path from the VM service, and passed it along to
api/serveAvailableExtensionsusing thepackageRootUriquery parameter. This meant that an untrusted caller could pass any directory on the host fileystem to probe directories or serve extensions outside of the active project directory.This deprecates the
packageRootUriquery parameter and replaces it withvmServiceUri, which allows the DevTools server to validatevmServiceUriand resolve the package root inVmServiceHandler.detectRootPackageForVmService.