Repository navigation
C#: convert data extensions to JSON - #23063
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The production C# data-extension pack now includes JSON model files, but the review lacks final-state DCA evidence and an assessment of changed results or regressions.
No open issues 🎉
What changed in this PR
This pull request migrates C# library models-as-data and test data extensions from YAML to JSON for faster loading with CodeQL CLI 2.27.3 while retaining YAML compatibility.
Changes:
- Converts C# library and generated
.model.ymlextensions to.model.json. - Converts C# test
.ext.ymlfixtures to.ext.json. - Updates
csharp/ql/lib/qlpack.ymlto discover both YAML and JSON model extensions.
| File | Description |
|---|---|
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureSourceModels.ext.yml | YAML test data extension converted to JSON. |
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureSourceModels.ext.json | JSON replacement for the converted YAML test data extension. |
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureSinkModels.ext.yml | YAML test data extension converted to JSON. |
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureSinkModels.ext.json | JSON replacement for the converted YAML test data extension. |
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureNeutralModels.ext.yml | YAML test data extension converted to JSON. |
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureNeutralModels.ext.json | JSON replacement for the converted YAML test data extension. |
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureHeuristicSummaryModels.ext.yml | YAML test data extension converted to JSON. |
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureHeuristicSummaryModels.ext.json | JSON replacement for the converted YAML test data extension. |
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureContentSummaryModels.ext.yml | YAML test data extension converted to JSON. |
| csharp/ql/test/utils/modelgenerator/dataflow/CaptureContentSummaryModels.ext.json | JSON replacement for the converted YAML test data extension. |
| csharp/ql/test/utils/modeleditor/FrameworkModeEndpoints.ext.yml | YAML model-editor data extension converted to JSON. |
| csharp/ql/test/utils/modeleditor/FrameworkModeEndpoints.ext.json | JSON replacement for the converted YAML model-editor data extension. |
| csharp/ql/test/query-tests/Security Features/CWE-643/XPathInjection.ext.yml | YAML XPath-injection test extension converted to JSON. |
| csharp/ql/test/query-tests/Security Features/CWE-643/XPathInjection.ext.json | JSON replacement for the XPath-injection test extension. |
| csharp/ql/test/query-tests/Security Features/CWE-134/UncontrolledFormatString.ext.yml | YAML uncontrolled-format-string test extension converted to JSON. |
| csharp/ql/test/query-tests/Security Features/CWE-134/UncontrolledFormatString.ext.json | JSON replacement for the uncontrolled-format-string test extension. |
| csharp/ql/test/query-tests/Security Features/CWE-094/CodeInjection.ext.yml | YAML code-injection test extension converted to JSON. |
| csharp/ql/test/query-tests/Security Features/CWE-094/CodeInjection.ext.json | JSON replacement for the code-injection test extension. |
| csharp/ql/test/query-tests/Security Features/CWE-090/LDAPInjection.ext.yml | YAML LDAP-injection test extension converted to JSON. |
| csharp/ql/test/query-tests/Security Features/CWE-090/LDAPInjection.ext.json | JSON replacement for the LDAP-injection test extension. |
| csharp/ql/test/query-tests/Security Features/CWE-089/SqlInjection.ext.yml | YAML SQL-injection test extension converted to JSON. |
| csharp/ql/test/query-tests/Security Features/CWE-089/SqlInjection.ext.json | JSON replacement for the SQL-injection test extension. |
| csharp/ql/test/query-tests/Security Features/CWE-089-2/SqlInjection.ext.yml | YAML SQL-injection test extension converted to JSON. |
| csharp/ql/test/query-tests/Security Features/CWE-089-2/SqlInjection.ext.json | JSON replacement for the SQL-injection test extension. |
| csharp/ql/test/query-tests/Security Features/CWE-079/StoredXSS/StoredXSS.ext.yml | YAML stored-XSS test extension converted to JSON. |
| csharp/ql/test/query-tests/Security Features/CWE-079/StoredXSS/StoredXSS.ext.json | JSON replacement for the stored-XSS test extension. |
| csharp/ql/test/query-tests/Security Features/CWE-078/CommandInjection.ext.yml | YAML command-injection test extension converted to JSON. |
| csharp/ql/test/query-tests/Security Features/CWE-078/CommandInjection.ext.json | JSON replacement for the command-injection test extension. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest6.ext.yml | YAML threat-model flow-test extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest6.ext.json | JSON replacement for the threat-model flow-test extension. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest5.ext.yml | YAML threat-model flow-test extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest5.ext.json | JSON replacement for the threat-model flow-test extension. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest4.ext.yml | YAML threat-model flow-test extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest4.ext.json | JSON replacement for the threat-model flow-test extension. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest3.ext.yml | YAML threat-model flow-test extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest3.ext.json | JSON replacement for the threat-model flow-test extension. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest2.ext.yml | YAML threat-model flow-test extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest2.ext.json | JSON replacement for the threat-model flow-test extension. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest1.ext.yml | YAML threat-model flow-test extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest1.ext.json | JSON replacement for the threat-model flow-test extension. |
| csharp/ql/test/library-tests/dataflow/flowsources/stored/file/Files.ext.yml | YAML file-source extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/flowsources/stored/file/Files.ext.json | JSON replacement for the file-source extension. |
| csharp/ql/test/library-tests/dataflow/flowsources/stored/database/dapper/DatabaseSources.ext.yml | YAML database-source extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/flowsources/stored/database/dapper/DatabaseSources.ext.json | JSON replacement for the database-source extension. |
| csharp/ql/test/library-tests/dataflow/flowsources/local/registry/Registry.ext.yml | YAML registry-source extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/flowsources/local/registry/Registry.ext.json | JSON replacement for the registry-source extension. |
| csharp/ql/test/library-tests/dataflow/flowsources/local/commandargs/CommandLineFlow.ext.yml | YAML command-line flow extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/flowsources/local/commandargs/CommandLineFlow.ext.json | JSON replacement for the command-line flow extension. |
| csharp/ql/test/library-tests/dataflow/flowsources/local/commandargs/CommandArgs.ext.yml | YAML command-line source extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/flowsources/local/commandargs/CommandArgs.ext.json | JSON replacement for the command-line source extension. |
| csharp/ql/test/library-tests/dataflow/external-models/sinks.ext.yml | YAML external-sink extension converted to JSON. |
| csharp/ql/test/library-tests/dataflow/external-models/sinks.ext.json | JSON replacement for the external-sink extension. |
| csharp/ql/lib/qlpack.yml | Adds JSON model-extension patterns alongside the existing YAML patterns. |
| csharp/ql/lib/ext/Windows.Security.Cryptography.Core.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/Windows.Security.Cryptography.Core.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Xml.Schema.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Xml.Schema.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Web.UI.WebControls.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Web.UI.WebControls.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Text.RegularExpressions.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Text.RegularExpressions.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Security.Policy.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Security.Policy.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Security.Permissions.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Security.Permissions.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Security.Cryptography.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Security.Cryptography.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Runtime.Serialization.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Runtime.Serialization.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Runtime.CompilerServices.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Runtime.CompilerServices.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Net.WebSockets.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Net.WebSockets.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Net.Sockets.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Net.Sockets.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Net.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Net.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Net.Mail.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Net.Mail.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Net.Http.model.yml | YAML model extension superseded by the existing JSON model. |
| csharp/ql/lib/ext/System.Net.Http.Headers.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Net.Http.Headers.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.IO.Compression.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.IO.Compression.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Dynamic.model.json | Existing C# model extension represented in JSON format. |
| csharp/ql/lib/ext/System.Data.SQLite.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Data.SQLite.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Data.SqlClient.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Data.SqlClient.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Data.OleDb.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Data.OleDb.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Data.Odbc.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Data.Odbc.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Data.EntityClient.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Data.EntityClient.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Data.Entity.model.yml | YAML model extension superseded by the existing JSON model. |
| csharp/ql/lib/ext/System.Configuration.Provider.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.Configuration.Provider.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Configuration.model.yml | YAML model extension superseded by the existing JSON model. |
| csharp/ql/lib/ext/System.ComponentModel.Design.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.ComponentModel.Design.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/System.Collections.ObjectModel.model.yml | YAML model extension superseded by the existing JSON model. |
| csharp/ql/lib/ext/System.CodeDom.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/System.CodeDom.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/NHibernate.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/NHibernate.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/Microsoft.Win32.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/Microsoft.Win32.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/Microsoft.VisualBasic.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/Microsoft.VisualBasic.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/Microsoft.JSInterop.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/Microsoft.JSInterop.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/Microsoft.Extensions.Configuration.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/Microsoft.Extensions.Configuration.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/Microsoft.AspNetCore.WebUtilities.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/Microsoft.AspNetCore.WebUtilities.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/Microsoft.AspNetCore.Mvc.model.json | Existing C# model extension represented in JSON format. |
| csharp/ql/lib/ext/Microsoft.AspNetCore.Http.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/Microsoft.AspNetCore.Http.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/Microsoft.AspNetCore.Components.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/Microsoft.AspNetCore.Components.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/Microsoft.AspNetCore.Components.CompilerServices.model.yml | YAML C# model extension converted to JSON. |
| csharp/ql/lib/ext/Microsoft.AspNetCore.Components.CompilerServices.model.json | JSON replacement for the C# model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Windows.Markup.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Windows.Markup.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Windows.Input.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Windows.Input.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Timers.model.yml | YAML model extension superseded by the existing JSON model. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Text.RegularExpressions.Generator.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Text.RegularExpressions.Generator.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Text.Json.Schema.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Text.Json.Schema.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Speech.AudioFormat.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Speech.AudioFormat.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Security.Authentication.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Security.Authentication.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.Serialization.Formatters.Binary.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.Serialization.Formatters.Binary.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.Remoting.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.Remoting.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.InteropServices.Swift.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.InteropServices.Swift.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.InteropServices.ObjectiveC.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.InteropServices.ObjectiveC.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.InteropServices.Java.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.InteropServices.Java.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.ConstrainedExecution.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.ConstrainedExecution.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.Caching.Hosting.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Runtime.Caching.Hosting.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Reflection.Context.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Reflection.Context.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Net.PeerToPeer.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Net.PeerToPeer.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Net.PeerToPeer.Collaboration.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Net.PeerToPeer.Collaboration.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Net.Http.Metrics.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Net.Http.Metrics.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Net.Cache.model.yml | YAML model extension superseded by the existing JSON model. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Linq.Expressions.Interpreter.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Linq.Expressions.Interpreter.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Drawing.Printing.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Drawing.Printing.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Diagnostics.PerformanceData.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Diagnostics.PerformanceData.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Data.SqlClient.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Data.SqlClient.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Data.OracleClient.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/System.Data.OracleClient.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/System.ComponentModel.DataAnnotations.Schema.model.yml | YAML model extension superseded by the existing JSON model. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.NETCore.Platforms.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.NETCore.Platforms.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Interop.JavaScript.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Interop.JavaScript.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Options.Generators.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Options.Generators.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.TraceSource.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.TraceSource.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.EventSource.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.EventSource.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.EventLog.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.EventLog.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.Debug.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.Debug.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.Configuration.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Logging.Configuration.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Internal.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Internal.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Http.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Http.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.FileSystemGlobbing.Internal.Patterns.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.FileSystemGlobbing.Internal.Patterns.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.FileProviders.Internal.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.FileProviders.Internal.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.FileProviders.Composite.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.FileProviders.Composite.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Diagnostics.Metrics.Configuration.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Diagnostics.Metrics.Configuration.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.Xml.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.Xml.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.UserSecrets.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.UserSecrets.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.Memory.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.Memory.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.Json.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.Json.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.Ini.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.Ini.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.EnvironmentVariables.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.EnvironmentVariables.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.CommandLine.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Extensions.Configuration.CommandLine.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.DotNet.PlatformAbstractions.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.DotNet.PlatformAbstractions.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Diagnostics.Tools.Pgo.TypeRefTypeSystem.model.yml | YAML model extension superseded by the existing JSON model. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Diagnostics.JitTrace.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.Diagnostics.JitTrace.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.CSharp.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Microsoft.CSharp.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/IntrinsicsInSystemPrivateCoreLib.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/IntrinsicsInSystemPrivateCoreLib.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Internal.NativeFormat.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Internal.NativeFormat.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/Internal.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Internal.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/ILLink.Shared.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/ILLink.Shared.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/ILLink.RoslynAnalyzer.TrimAnalysis.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/ILLink.RoslynAnalyzer.TrimAnalysis.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/ILCompiler.Reflection.ReadyToRun.RiscV64.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/ILCompiler.Reflection.ReadyToRun.RiscV64.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/ILCompiler.Reflection.ReadyToRun.LoongArch64.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/ILCompiler.Reflection.ReadyToRun.LoongArch64.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/ILCompiler.Reflection.ReadyToRun.Arm64.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/ILCompiler.Reflection.ReadyToRun.Arm64.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/ILCompiler.Reflection.ReadyToRun.Arm.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/ILCompiler.Reflection.ReadyToRun.Arm.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/generated/modelgenerator/ILCompiler.IBC.model.yml | YAML model extension superseded by the existing JSON model. |
| csharp/ql/lib/ext/generated/modelgenerator/Generators.model.yml | YAML generated model extension converted to JSON. |
| csharp/ql/lib/ext/generated/modelgenerator/Generators.model.json | JSON replacement for the generated model extension. |
| csharp/ql/lib/ext/empty.model.yml | YAML empty model extension converted to JSON. |
| csharp/ql/lib/ext/empty.model.json | JSON replacement for the empty model extension. |
Review effort: Lite (auto)
|
If it helps ease a reviewer's concerns, I used the exact same approach here as in the PRs for other languages that have been merged in recent days (without any reported issues so far). |
michaelnebel
left a comment
There was a problem hiding this comment.
Thank you very much for doing this @nickrolfe !
A couple of questions/comments.
- I inspected a couple of diffs and they look 👍
- For the first commit the "File filter" indicates that there are 341 files but only 306 yml files?
- It looks like the linked DCA run is still in progress (perhaps it is stuck). Maybe start a new one?
I think this can be explained by the fact that git considers some of the changes to be renames (
So the 341 you saw is probably adding the 305 added
I've kicked off a new one. |
michaelnebel
left a comment
There was a problem hiding this comment.
LGTM!
The PR can be merged, if DCA doesn't show any problems.
|
DCA results look unremarkable; merging… |
CodeQL CLI 2.27.3 supports JSON data extensions (aka MaD models), and can load them significantly faster than YAML. This PR converts those in C#'s library pack (first commit), along with
$TEST.ext.ymlfiles (second commit). The conversions were automated by an LLM-generated Python script (which I will add in a separate PR).Although JSON is preferred going forward,
csharp/ql/lib/qlpack.ymlnow has patterns that will pick up both.model.ymland.model.jsonfiles, so that any YAML files that do get checked in won't get silently dropped.To verify successful conversion in the first commit, I cherry-picked it onto #23062, which has a temporary test that enumerates all tuples from data extensions. The test still passes after conversion.
For the second commit, I sampled several of the converted files and manually inspected the diffs.