Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Provider-revision errors can prevent Hub startup or fail to invalidate in-flight authentication after credential rotation, while stale trusted-proxy settings can weaken authentication rate limits.
11 open issues
Coordinate Entra callback updates when changing the shared origin · New Verify persisted provider revision before enforcing consecutive revisions · New Include deployed secret-reference changes in provider revision updates · New Prevent unrelated saved values from overriding live settings · New Validate canonical full origins before applying changes · New Preserve secret-backed proxy-hop configuration when saving inputs · New Preserve the existing vault secret name during credential rotation · New Reject pending journals with mismatched input hashes · New Require version-pinned runtime references before restart · New Preserve recovery guidance in the final error summary · New Resolve pending credential writes before allowing another upload · New
What changed in this PR
Adds a resumable Azure installer workflow so operators can finish configuring an already deployed Hub without rebuilding its image or rerunning database setup.
Changes:
- Adds post-setup actions for sign-in/setup access, GitHub App configuration, and restarting Hub.
- Saves validated answers and secret references, with recovery journals, leases, and scoped Terraform checks.
- Adds command routing, regression coverage, and operator documentation.
Live Hub, Key Vault, and GitHub App validation remains outstanding.
| File | Description |
|---|---|
package.json |
Adds the root setup:post command. |
infrastructure/vitest.config.ts |
Includes post-setup tests. |
infrastructure/tsconfig.json |
Includes post-setup TypeScript source. |
infrastructure/README.md |
Documents configuration, restart, and recovery workflows. |
infrastructure/installer/types.ts |
Defines supported post-setup actions. |
infrastructure/installer/index.tsx |
Routes post-setup commands and handles cancellation. |
infrastructure/installer/entry/index.ts |
Adds the post-setup menu and installation selection. |
infrastructure/installer/entry/index.test.ts |
Covers selection, exit, and unfinished-operation guards. |
infrastructure/installer/command/describe/index.ts |
Adds safe labels for new Azure operations. |
infrastructure/installer/command/default-signal/index.ts |
Preserves caller-supplied cleanup signals. |
infrastructure/installer/command/default-signal/index.test.ts |
Covers default and cleanup signal behavior. |
infrastructure/docs/terminal-design.md |
Defines prompt persistence and recovery-feedback behavior. |
infrastructure/azure/post/verify/index.ts |
Checks readiness, protected setup, and GitHub availability. |
infrastructure/azure/post/verify/index.test.ts |
Covers setup-access and provider checks. |
infrastructure/azure/post/validate-plan/index.ts |
Restricts Terraform changes to the approved scope. |
infrastructure/azure/post/validate-plan/index.test.ts |
Covers allowed updates and blocked drift. |
infrastructure/azure/post/types.ts |
Defines deployment and desired-input contracts. |
infrastructure/azure/post/progress/index.ts |
Persists validated answers and secret-write checkpoints. |
infrastructure/azure/post/progress/index.test.ts |
Covers persistence, isolation, conflicts, and file safety. |
infrastructure/azure/post/index.ts |
Coordinates configuration, restart, locking, and recovery. |
infrastructure/azure/post/index.test.ts |
Covers orchestration, cancellation, and retry behavior. |
infrastructure/azure/post/errors.ts |
Adds a resumable post-setup exit exception. |
infrastructure/azure/post/deployment/index.ts |
Validates deployment identity, revisions, traffic, and jobs. |
infrastructure/azure/post/deployment/index.test.ts |
Covers deployment discovery and safety guards. |
infrastructure/azure/post/credential-file/index.ts |
Reads private credential files and validates their format. |
infrastructure/azure/post/configure/index.ts |
Collects answers and prepares authentication secret references. |
infrastructure/azure/post/configure/index.test.ts |
Covers prompt recovery, secret reuse, and credential uploads. |
Review effort: Max (adaptive)
Add the existing-installation menu for setup access, GitHub App settings, and active revision restart. Preserve validated progress and pinned Key Vault checkpoints, recover invalid input in place, and gate runtime-only changes with fresh plans and lease ownership checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Post-setup accepted any GitHub provider revision at or above the deployed one when settings were unchanged, but Hub only starts with the deployed revision or its immediate successor. Changed settings still require the next revision. The CLI command runner always replaced the caller's signal with the session signal, so lease cleanup after cancellation aborted immediately and left owned leases held. The runner now applies the session signal only when the caller supplies none. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
weastler
force-pushed
the
weastler/stack-6-post-setup
branch
from
November 17, 2026 07:06
a2d8636 to
6f83912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why
Several settings can be configured only after Hub is deployed. Configuring them by hand is error-prone, and an interruption can lose the operator's progress.
This is layer 6, the top of a six-layer stack on
build/hub/newat1f5b485e. It is based on layer 5, terminal handoff.What changes
A new
setup:postcommand finishes configuration after deployment. It saves progress so an operator can resume, keeps entered input after a recoverable error, and checkpoints to Key Vault. Revisions must be consecutive, and the cleanup signal is preserved when an update is interrupted. The prompt and progress validators use layer 4's shared origin parser, so post-setup accepts the same canonical origins as the installer. This layer also updates the related docs andpackage.jsonscripts.The infrastructure typecheck and full suite pass (1,087 tests), and the Terraform checks match layer 4.
setup:posthas not been run against a live Hub, Key Vault or GitHub App.