Repository navigation
Keep one live hub connection across project pages - #1687
Conversation
A Turbo visit between project pages closed and reopened the Mercure connection because each page asked for its own topics and mercure.js reopened on any difference. Every project page now asks for one set of project topics from a shared partial, and the page script keeps the open connection when it already carries every topic of the next page. A page that needs a new topic still reopens. The set follows the sidebar project, so a page outside a project keeps the live counters of the last visited project. Document review pages keep their per-document topic (decision D1, option 1). Each topic still passes its own authorizer, so access control is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Loupe agent review of The shared topics and covering connection match the design. The required page previews and WebTestCase coverage are incomplete. Visual check: read the record; no prototype is linked.
|
|
Loupe queued a fix run for this pull request. Reason: the agent review found problems |
Rule: every project page renders the same topic inputs, so the test must request each named page (Board, Inbox, Agents, Documents list, Workshop) and compare the sets. The test now switches the inbox flag on, requests all five pages, and checks the Board, Documents and Inbox topics are present. The account case now checks the worker runs, inbox and documents topics are absent before a project visit and present after it. Loupe-Fix-Round: agent-review Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Loupe agent review of The topic set and covering connection match the approved design. The account page with a remembered project lacks required preview proof. Visual check: read the record; no prototype is linked.
|
|
Loupe queued a fix run for this pull request. Reason: the agent review found problems |
|
Loupe agent review of The shared topic set and connection reuse follow the design. The full-screen artifact preview claims no data although it shows an artifact record. Visual check: read the record; no prototype is linked.
|
|
Loupe queued a fix run for this pull request. Reason: the agent review found problems |
|
Loupe agent review of The shared topic code follows the design. The artifact and account preview states lack valid proof. Visual check: read the record only; no prototype is linked.
|
|
Loupe queued a fix run for this pull request. Reason: the agent review found problems |
|
Loupe agent review of The shared topics and covering connection follow the approved design. The account preview state has no signed link. Visual check: read the record only; no prototype is linked.
|
|
Loupe queued a fix run for this pull request. Reason: checks failed |
The account page keeps the topics of the remembered project, and a signed preview link carries no session, so the state could not be linked. The dev preview login now writes the oldest project of the account into the session, so a link to /account/profile shows the remembered-project topics. Loupe-Fix-Round: checks-failed Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Loupe agent review of The shared topics and covering connection follow the approved design. The account page lacks preview proof for its no-project state. Visual check: read the record only; no prototype is linked.
|
|
Loupe queued a fix run for this pull request. Reason: the agent review found problems |
|
Loupe queued a fix run for this pull request. Reason: the agent review found problems |
|
Loupe agent review of The shared topics and covering connection follow the approved design. The account preview and cookie-path test need correction. Visual check: record only; no prototype is linked.
|
The earlier test visited a project page, which sets the session value, so it covered only the session fallback. The new test sets CurrentProjectProvider::LAST_VISITED_COOKIE on the client and asserts the project topics appear on the account page, with the no-project reading before it as the guard. Loupe-Fix-Round: agent-review Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Loupe queued a fix run for this pull request. Reason: checks failed |
Every project page now subscribes to one shared set of topics. The board, backlog and inbox tests and the board live-refresh e2e spec asserted the old exact lists. They now assert that the topics they care about are present, and that the inbox topic is absent while the inbox is off. Loupe-Fix-Round: checks-failed Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Loupe queued a fix run for this pull request. Reason: checks failed |
Preview
Built from commit 017cbc7.
dashboard" data-mercure-topic, no datadashboard" data-mercure-topic, no datadashboard" data-mercure-topic, no datadashboard" data-mercure-topic, no datadata-artifact-card-link, empty/projects/e6b95a75-599c-57ee-af01-800d3047f766/artifacts/a00dc9ce-1c7d-5dfa-a659-0fd2fc4865d2/full-screendata-mercure-topic, no datadata-mercure-topic, no dataThe dev preview login remembers the oldest project of the account. The marker counts 11 on the account page of the seeded
projects-many@loupe.test, which owns 24 projects, and 1 on the account page ofmember@loupe.test, which owns none.ProjectLiveTopicsTestalso covers it.Card: https://app.loupe.ac/projects/01a007cc-5419-7085-a0a2-23a0875be12c/board/cards/01a1e4fd-1d3d-7698-89a7-3479cac4b95d
Every project page now asks for the same ten live topics from one partial. The page script keeps the open hub connection when it already carries every topic of the next page. Document review pages keep their own topic and open one new connection (decision D1, option 1).
Gate: cs, phpstan, arkitect, gamache,
just js-testonmercure.test.js, andProjectLiveTopicsTestgreen. The saving is not measured.🤖 Generated with Claude Code