Skip to content

Keep one live hub connection across project pages - #1687

Merged
loupe-ac[bot] merged 20 commits into
mainfrom
card-1582-live-hub-connection
Nov 17, 2026
Merged

loupe-ac[bot] merged 20 commits into
mainfrom
card-1582-live-hub-connection

Conversation

@loupe-ac

@loupe-ac loupe-ac Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Preview

Built from commit 017cbc7.

The dev preview login remembers the oldest project of the account. The marker counts 11 on the account page of the seeded projects-many@loupe.test, which owns 24 projects, and 1 on the account page of member@loupe.test, which owns none. ProjectLiveTopicsTest also covers it.

Card: https://app.loupe.ac/projects/01a007cc-5419-7085-a0a2-23a0875be12c/board/cards/01a1e4fd-1d3d-7698-89a7-3479cac4b95d

Every project page now asks for the same ten live topics from one partial. The page script keeps the open hub connection when it already carries every topic of the next page. Document review pages keep their own topic and open one new connection (decision D1, option 1).

Gate: cs, phpstan, arkitect, gamache, just js-test on mercure.test.js, and ProjectLiveTopicsTest green. The saving is not measured.

🤖 Generated with Claude Code

claude-force-one and others added 3 commits November 16, 2026 12:13
A Turbo visit between project pages closed and reopened the Mercure
connection because each page asked for its own topics and mercure.js
reopened on any difference.

Every project page now asks for one set of project topics from a shared
partial, and the page script keeps the open connection when it already
carries every topic of the next page. A page that needs a new topic still
reopens. The set follows the sidebar project, so a page outside a project
keeps the live counters of the last visited project. Document review pages
keep their per-document topic (decision D1, option 1).

Each topic still passes its own authorizer, so access control is unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe agent review of 703bd39: failed, 2 important findings

The shared topics and covering connection match the design. The required page previews and WebTestCase coverage are incomplete. Visual check: read the record; no prototype is linked.

  • important · Spec · Preview: Prove the other changed page states
  • important · tests/Module/Project/Controller/ProjectLiveTopicsTest.php:25-27 · Cover the Board and Inbox topic sets in the WebTestCase

See the check · Open the card

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe queued a fix run for this pull request.

Reason: the agent review found problems
Round: 1 of 10

Open the card and its runs in Loupe

claude-force-one and others added 2 commits November 16, 2026 12:24
Rule: every project page renders the same topic inputs, so the test must
request each named page (Board, Inbox, Agents, Documents list, Workshop) and
compare the sets. The test now switches the inbox flag on, requests all five
pages, and checks the Board, Documents and Inbox topics are present. The
account case now checks the worker runs, inbox and documents topics are
absent before a project visit and present after it.

Loupe-Fix-Round: agent-review
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe agent review of 2677719: failed, 1 important finding

The topic set and covering connection match the approved design. The account page with a remembered project lacks required preview proof. Visual check: read the record; no prototype is linked.

  • important · Spec · Preview: Prove the account page with a remembered project

See the check · Open the card

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe queued a fix run for this pull request.

Reason: the agent review found problems
Round: 2 of 10

Open the card and its runs in Loupe

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe agent review of 2677719: failed, 1 important finding

The shared topic set and connection reuse follow the design. The full-screen artifact preview claims no data although it shows an artifact record. Visual check: read the record; no prototype is linked.

  • important · Spec · Preview: Prove the full-screen artifact as a data state

See the check · Open the card

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe queued a fix run for this pull request.

Reason: the agent review found problems
Round: 3 of 10

Open the card and its runs in Loupe

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe agent review of 2677719: failed, 2 important findings

The shared topic code follows the design. The artifact and account preview states lack valid proof. Visual check: read the record only; no prototype is linked.

  • important · Spec · Preview: Prove the artifact record with a data marker and an empty twin
  • important · Spec · Preview: Link to the account page state

See the check · Open the card

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe queued a fix run for this pull request.

Reason: the agent review found problems
Round: 4 of 10

Open the card and its runs in Loupe

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe agent review of 2677719: failed, 1 important finding

The shared topics and covering connection follow the approved design. The account preview state has no signed link. Visual check: read the record only; no prototype is linked.

  • important · Spec · Preview: Provide the remembered-project account state

See the check · Open the card

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe queued a fix run for this pull request.

Reason: checks failed
Round: 1 of 3

Open the card and its runs in Loupe

The account page keeps the topics of the remembered project, and a signed preview link carries no session, so the state could not be linked. The dev preview login now writes the oldest project of the account into the session, so a link to /account/profile shows the remembered-project topics.

Loupe-Fix-Round: checks-failed

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe agent review of 6b6cc03: failed, 1 important finding

The shared topics and covering connection follow the approved design. The account page lacks preview proof for its no-project state. Visual check: read the record only; no prototype is linked.

  • important · Spec · Preview: Prove the account page without a remembered project

See the check · Open the card

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe queued a fix run for this pull request.

Reason: the agent review found problems
Round: 5 of 10

Open the card and its runs in Loupe

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe queued a fix run for this pull request.

Reason: the agent review found problems
Round: 6 of 10

Open the card and its runs in Loupe

@loupe-ac

loupe-ac Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Loupe agent review of 6b6cc03: failed, 2 important findings

The shared topics and covering connection follow the approved design. The account preview and cookie-path test need correction. Visual check: record only; no prototype is linked.

  • important · Spec · Preview: Use a seeded demo account for the remembered-project state
  • important · tests/Module/Project/Controller/ProjectLiveTopicsTest.php:57-59 · Test the remembered project cookie path

See the check · Open the card

claude-force-one and others added 6 commits November 16, 2026 13:35
The earlier test visited a project page, which sets the session value,
so it covered only the session fallback. The new test sets
CurrentProjectProvider::LAST_VISITED_COOKIE on the client and asserts
the project topics appear on the account page, with the no-project
reading before it as the guard.

Loupe-Fix-Round: agent-review
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@loupe-ac

loupe-ac Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Loupe queued a fix run for this pull request.

Reason: checks failed
Failed checks: e2e-chromium, phpunit
Round: 2 of 3

Open the card and its runs in Loupe

claude-force-one and others added 2 commits November 16, 2026 20:56
Every project page now subscribes to one shared set of topics. The board,
backlog and inbox tests and the board live-refresh e2e spec asserted the old
exact lists. They now assert that the topics they care about are present, and
that the inbox topic is absent while the inbox is off.

Loupe-Fix-Round: checks-failed
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@loupe-ac
loupe-ac Bot marked this pull request as ready for review November 17, 2026 06:16
@loupe-ac

loupe-ac Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Loupe queued a fix run for this pull request.

Reason: checks failed
Round: 1 of 3

Open the card and its runs in Loupe

@loupe-ac
loupe-ac Bot merged commit a723313 into main Nov 17, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant