Repository navigation
Fix flaky fanotify cross-watcher test - #65609
Open
Jake Bailey (jakebailey) wants to merge 1 commit into
Open
Jake Bailey (jakebailey) wants to merge 1 commit into
Jake Bailey (jakebailey) wants to merge 1 commit into
Conversation
A file rewrite can produce multiple update notifications across debounce batches. The cross-watcher test only needs to verify delivery to the intended watch and isolation from the other watch.
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch)
and
a balanced review from Copilot
November 20, 2026 18:39
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the test change that tolerates duplicate fanotify update events.
No open issues 🎉
What changed in this PR
This PR reduces flakiness in the Linux fanotify cross-watcher test by allowing duplicate update events from a single file write.
Changes:
- Replaces exact event-set matching with
expectContainsfor watcher A. - Preserves the check that watcher B receives no phantom events.
| File | Description |
|---|---|
tsc/internal/fswatch/fanotify_linux_test.go |
Relaxes the modify-event assertion to tolerate duplicate OS notifications. |
Review effort: Balanced
Andrew Branch (andrewbranch)
approved these changes
Nov 20, 2026
Jake Bailey (jakebailey)
enabled auto-merge
November 20, 2026 18:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the OS will emit multiple events, especially given file writes could be non-atomic. Just loosen the test expectations.