Repository navigation
[heft-web-rig] Add an "app" profile, upgrade to Webpack 5, implement new CSS rules - #3204
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
@rushstack/heft-web-rigwith a bunch of new features.Details
useUnknownInCatchVariables": falseto work around Allow "catch (e as Error)" instead of "catch (e: unknown)" TypeScript#42596webpack.config.jsdefaults from the rig usingwebpack-mergemini-css-extract-plugin,css-minimizer-webpack-plugin,webpack-bundle-analyzerImport.resolveModule()to ensurerequire('webpack')finds the correct instanceRelated ideas that are outside the scope of this PR:
node-sasswithsassforheft-sass-pluginlib-commonjswithemitCjsExtensionForCommonJS@rushstack/heft-node-rigstrictPeerDependencies fix
While trying to get the various Webpack 5 plugin versions straightened out, I encountered a bunch of peer dependency issues. The
strictPeerDependenciesvalidation for this repo apparently got disabled by accident a few months ago, and a bunch of warnings accumulated in the interim. Ideally that should be solved in a separate PR with its own code review, but in the interest of time it is more efficient to solve the equation with the final set of package.json files, so I've rolled it into this PR. Sorry for the huge diff. :-)How it was tested
The new
@rushstack/heft-web-rigwas prototyped in therushstack.io-servicerepo.CC Ian Clanton-Thuon (@iclanton) Elliot Nelson (@elliot-nelson) David Michon (@dmichon-msft)