Repository navigation
Conversation
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3863. If a maintainer assigns you to #3863, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Fixes #3863
Summary
has_modern_envelope()inmcp.shared.inbound(reused by bothmcp.server.runnerandStreamableHTTPSessionManager).StreamableHTTPSessionManager._handle_request(), when aPOSTrequest carries a 2025-era or missingMCP-Protocol-Versionheader, inspect the buffered body once (with an ASGIreplaywrapper) and route non-initializerequests carryingparams._meta['io.modelcontextprotocol/protocolVersion']tohandle_modern_request(), whereclassify_inbound_requestrejects the mismatch with400/-32020(HEADER_MISMATCH).Verification
test_modern_envelope_routes_to_modern_handler_regardless_of_headerintests/server/test_streamable_http_manager.py(covering both2025-11-25and missing headers).uv run pyright: 0 errors, 0 warnings.uv run ruff check: all checks passed.uv run pytest tests/server/test_streamable_http_manager.py tests/server/test_streamable_http_modern.py: 124 passed.