Skip to content

fix: match green-button (#N) only on the summary line - #42

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:match-green-button-only-summary-line
Open

trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:match-green-button-only-summary-line

Conversation

@trivikr

@trivikr trivikr commented Nov 20, 2026

Copy link
Copy Markdown
Member

A commit message line ending in (#N) set prUrl/ghIssue no matter where it appeared. Body lines such as see also (#12), or squash-merge entries like * fix: foo (#7), overwrote the PR number taken from the summary and were dropped from description.

For example, with this message the result was ghIssue: 7 and description: ['Body line']:

    feat: thing (#41)

    Body line
    see also (#12)
    * fix: squashed (#7)

The (#N) match, added for green-button merges in 9e87160, now applies only to the summary line. Other lines go to description as usual. PR-URL: trailers are unchanged.

Adds a test for each triggering body line. Both fail without the fix.

A body line ending in "(#N)", such as "see also (nodejs#12)" or a squash-merge
entry "* fix: foo (nodejs#7)", overwrote prUrl/ghIssue and was dropped from
description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant