Skip to content

feat(ncu-ci): link failed PRs to GitHub in reports - #1249

Open
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:reliability-pr-links
Open

inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:reliability-pr-links

Conversation

@inoway46

@inoway46 inoway46 commented Nov 18, 2026 •

Copy link
Copy Markdown

In the reliability reports, each entry in the "Failed PR" row is labeled as a PR but links to its node-test-pull-request run. Readers without access to ci.nodejs.org cannot open that link, so they have no direct way to get to the PR that failed.

This links the label to the PR on GitHub and keeps the CI run as a separate link next to it:

-[nodejs/node#<number>](https://ci.nodejs.org/job/node-test-pull-request/<run>/)
+[nodejs/node#<number>](https://github.com/nodejs/node/pull/<number>) ([CI](https://ci.nodejs.org/job/node-test-pull-request/<run>/))

When target branches are shown, they follow the CI link in the same parentheses, e.g. (CI, target: v24.x). Sources that are not PRs still link to their CI run, and the terminal output is unchanged.

Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-11-18.md
Refs: #1217

The "Failed PR" row of the Markdown report labels each entry as a PR
(owner/repo#number) but links to its node-test-pull-request run.
Readers without access to ci.nodejs.org cannot open that link, so they
have no direct way to get to the PR that failed.

Link each label to the PR on GitHub and keep the CI run as a separate
"CI" link next to it, together with the target branches. Sources that
are not PRs keep linking to their CI run.

Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Assisted-by: Claude Code
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.49%. Comparing base (27468f5) to head (0a970a5).

Files with missing lines Patch % Lines
lib/ci/failure_aggregator.js 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   66.45%   66.49%   +0.03%     
==========================================
  Files          69       69              
  Lines       14202    14223      +21     
==========================================
+ Hits         9438     9457      +19     
- Misses       4764     4766       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant