Skip to content

buffer: fix backwards incompatibility - #12439

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:buffer-perf-fix-backwards-compat
Closed

mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:buffer-perf-fix-backwards-compat

Conversation

@mscdex

@mscdex mscdex commented Apr 16, 2017 •

Copy link
Copy Markdown
Contributor

4a86803 introduced a backwards incompatibility by accident and was not caught due to an existing test that wasn't strict enough.

This commit fixes both the backwards incompatibility and the test.

This changes does not affect performance.

CI: https://ci.nodejs.org/job/node-test-pull-request/7424/

/cc @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • buffer

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants