Skip to content

build: remove cctest extension - #16680

Closed
yhwang wants to merge 1 commit into
nodejs:masterfrom
yhwang:cctest-in-node-shared
Closed

yhwang wants to merge 1 commit into
nodejs:masterfrom
yhwang:cctest-in-node-shared

Conversation

@yhwang

@yhwang yhwang commented Nov 2, 2017 •

Copy link
Copy Markdown
Member

cctest appends so.59 when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fix the issue.

Signed-off-by: Yihong Wang yh.wang@ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.