Skip to content

Revert "src: ignore GCC -Wcast-function-type for v8.h" - #35758

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:remove-gcc-cast-function-type
Closed

danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:remove-gcc-cast-function-type

Conversation

@danbev

@danbev danbev commented Oct 22, 2020

Copy link
Copy Markdown
Contributor

This reverts commit f21cf45 as this has
now been included in the V8 version being used.

Refs:
v8/v8@f08cbfd

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants