Skip to content

test: change promises to async/await in test-debugger-backtrace.js - #44677

Merged
nodejs-github-bot merged 11 commits into
nodejs:mainfrom
zhangjuliet:main
Sep 29, 2022
Merged

nodejs-github-bot merged 11 commits into
nodejs:mainfrom
zhangjuliet:main

Conversation

@zhangjuliet

Copy link
Copy Markdown
Contributor

Signed-off-by: Juliet Zhang julietzhang3@gmail.com

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 16, 2022
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 16, 2022
@tniessen

Copy link
Copy Markdown
Member

This supersedes #44672 as far as I can tell. FWIW, you can also update/edit an existing pull request without having to open a new pull request. Let us know if we can help! :)

fix error resulting from unused result of immediately-invoked async function
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 17, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 17, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

ghost commented Sep 25, 2022

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 28, 2022
@nodejs-github-bot

ghost commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

ghost commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 29, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 19503e7 into nodejs:main Sep 29, 2022
@nodejs-github-bot

ghost commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

Landed in 19503e7

@Trott

ghost commented Sep 29, 2022

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants