Skip to content

tools: fix V8 update workflow - #52822

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:v8-auto-update
May 5, 2024
Merged

nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:v8-auto-update

Conversation

@aduh95

@aduh95 aduh95 commented May 3, 2024 •

Copy link
Copy Markdown
Contributor

IIUC the workflow is currently failing when an update is available because grep "V8 is up-to-date" returns a non-zero exit code. I tested locally, and can confirm it does fix the script.

Fixes: #50497

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V8 patch update workflow is broken

7 participants