Repository navigation
[v25.x] deps: V8: backport 209d2db9e24a - #61322
Conversation
commented
Jan 9, 2026
|
Review requested:
|
|
Scratch that - have confirmed the problem with a v25.x-staging build and also that this fixes it. Failure was as follows: |
commented
Jan 9, 2026
Ah, compilation error here should mean V8 JIT compilation error. I copied the words from the V8 commit msg, I have updated the description to avoid confusion. It appears that the 25.x-staging branch has been force pushed. I will rebase this PR shortly. |
commented
Jan 9, 2026
FYI it will be force pushed again next week when the security release gets released, you might prefer waiting for that before rebasing. |
commented
Jan 9, 2026
Thanks for the heads up. Let's wait until the security release is done. |
a8902ab to
9f2e230
Compare
commented
Jan 13, 2026
|
I just saw the 25.3 security release on oss-security mailing list. I have rebased this PR. |
commented
Jan 14, 2026
|
I don't think the CI failures are related. This PR only touches V8 RISC-V code, which is not even compiled in the CI. |
9f2e230 to
65696e4
Compare
commented
Jan 17, 2026
|
Rebased again since v25.x-staging got force-pushed again. Hopefully that would fix the CI. |
commented
Jan 17, 2026
commented
Jan 17, 2026
commented
Jan 17, 2026
commented
Jan 17, 2026
commented
Jan 17, 2026
Original commit message:
[riscv] Fix compilation error and disassembling error when enabling the RISC-V C extension
Change-Id: I34a930f7bcda514698ce64d132cbe05fa32b323c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6934163
Reviewed-by: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Reviewed-by: Kasper Lund <kasperl@rivosinc.com>
Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#102431}
Refs: v8/v8@209d2db
Co-authored-by: kxxt <rsworktech@outlook.com>
PR-URL: nodejs#61322
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
commented
Jan 20, 2026
|
Landed in e326df7 |
commented
Apr 4, 2026
|
Do we want/need this on 24.x? If so, we'd need a manual backport. If not, we can add the
dont-land-on-v24.x
|
commented
Apr 4, 2026
IIRC it is only meant for 25, but I will double check it. |
This PR fixes JIT compilation error and disassembling error when enabling the RISC-V C extension in V8.
This is only need in v25.x, the v8 version on the main branch already contains the fix.
Original commit message:
Refs: v8/v8@209d2db
Thanks for @luyahan for pointing out the fix and @RevySR for verifying it on node v25.2.1!