Skip to content

[v25.x] deps: V8: backport 209d2db9e24a - #61322

Merged
aduh95 merged 1 commit into
nodejs:v25.x-stagingfrom
kxxt:riscv-c-ext
Jan 20, 2026
Merged

aduh95 merged 1 commit into
nodejs:v25.x-stagingfrom
kxxt:riscv-c-ext

Conversation

@kxxt

@kxxt kxxt commented Jan 9, 2026 •

Copy link
Copy Markdown
Member

This PR fixes JIT compilation error and disassembling error when enabling the RISC-V C extension in V8.

This is only need in v25.x, the v8 version on the main branch already contains the fix.

Original commit message:

[riscv] Fix compilation error and disassembling error when enabling the RISC-V C extension

Change-Id: I34a930f7bcda514698ce64d132cbe05fa32b323c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6934163
Reviewed-by: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Reviewed-by: Kasper Lund <kasperl@rivosinc.com>
Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#102431}

Refs: v8/v8@209d2db

Thanks for @luyahan for pointing out the fix and @RevySR for verifying it on node v25.2.1!

@nodejs-github-bot

ghost commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v25.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 9, 2026
@sxa

ghost commented Jan 9, 2026 •

Copy link
Copy Markdown
Member

@kxxt Just to check - this is an issue at runtime when you run with --riscv-c-extension? I was a bit confused by this issue saying it was a compilation failure and thought it was something that showed up when you were running the node build ...

Scratch that - have confirmed the problem with a v25.x-staging build and also that this fixes it. Failure was as follows:

sxa@bananapif3:~$ ./node25xs1-vanilla --riscv-c-extension


#
# Fatal error in , line 0
# Check failed: kMaxSizeOfMoveAfterFastCall == pc_offset() - before_offset.
#
#
#
#FailureMessage Object: 0x3fdc0423a0
----- Native stack trace -----

 1: 0x5aee44  [./node25xs1-vanilla]
 2: 0x1d48566 V8_Fatal(char const*, ...) [./node25xs1-vanilla]
 3: 0x116c8da  [./node25xs1-vanilla]
 4: 0x116ca70  [./node25xs1-vanilla]
 5: 0x11863b6  [./node25xs1-vanilla]
 6: 0xe1c616  [./node25xs1-vanilla]
 7: 0xe44fbe  [./node25xs1-vanilla]
 8: 0xe45546  [./node25xs1-vanilla]
 9: 0xe46a48  [./node25xs1-vanilla]
10: 0xe6ddc8  [./node25xs1-vanilla]
11: 0x12e5e24  [./node25xs1-vanilla]
Trace/breakpoint trap
sxa@bananapif3:~$ 

@aduh95
aduh95 requested a review from a team as a code owner January 9, 2026 23:32
@kxxt

ghost commented Jan 9, 2026

Copy link
Copy Markdown
Member Author

@kxxt Just to check - this is an issue at runtime when you run with --riscv-c-extension? I was a bit confused by this issue saying it was a compilation failure and thought it was something that showed up when you were running the node build ...

Scratch that - have confirmed the problem with a v25.x-staging build and also that this fixes it. Failure was as follows:

sxa@bananapif3:~$ ./node25xs1-vanilla --riscv-c-extension


#
# Fatal error in , line 0
# Check failed: kMaxSizeOfMoveAfterFastCall == pc_offset() - before_offset.
#
#
#
#FailureMessage Object: 0x3fdc0423a0
----- Native stack trace -----

 1: 0x5aee44  [./node25xs1-vanilla]
 2: 0x1d48566 V8_Fatal(char const*, ...) [./node25xs1-vanilla]
 3: 0x116c8da  [./node25xs1-vanilla]
 4: 0x116ca70  [./node25xs1-vanilla]
 5: 0x11863b6  [./node25xs1-vanilla]
 6: 0xe1c616  [./node25xs1-vanilla]
 7: 0xe44fbe  [./node25xs1-vanilla]
 8: 0xe45546  [./node25xs1-vanilla]
 9: 0xe46a48  [./node25xs1-vanilla]
10: 0xe6ddc8  [./node25xs1-vanilla]
11: 0x12e5e24  [./node25xs1-vanilla]
Trace/breakpoint trap
sxa@bananapif3:~$ 

Ah, compilation error here should mean V8 JIT compilation error. I copied the words from the V8 commit msg, I have updated the description to avoid confusion.

It appears that the 25.x-staging branch has been force pushed. I will rebase this PR shortly.

@aduh95

ghost commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

It appears that the 25.x-staging branch has been force pushed. I will rebase this PR shortly.

FYI it will be force pushed again next week when the security release gets released, you might prefer waiting for that before rebasing.

@kxxt

ghost commented Jan 9, 2026

Copy link
Copy Markdown
Member Author

It appears that the 25.x-staging branch has been force pushed. I will rebase this PR shortly.

FYI it will be force pushed again next week when the security release gets released, you might prefer waiting for that before rebasing.

Thanks for the heads up. Let's wait until the security release is done.

@kxxt

ghost commented Jan 13, 2026

Copy link
Copy Markdown
Member Author

I just saw the 25.3 security release on oss-security mailing list.

I have rebased this PR.

@kxxt

ghost commented Jan 14, 2026

Copy link
Copy Markdown
Member Author

I don't think the CI failures are related. This PR only touches V8 RISC-V code, which is not even compiled in the CI.

@kxxt

ghost commented Jan 17, 2026

Copy link
Copy Markdown
Member Author

Rebased again since v25.x-staging got force-pushed again. Hopefully that would fix the CI.

@nodejs-github-bot

ghost commented Jan 17, 2026

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

ghost commented Jan 17, 2026

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

ghost commented Jan 17, 2026

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

ghost commented Jan 17, 2026

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

ghost commented Jan 17, 2026

Copy link
Copy Markdown
Collaborator

Original commit message:

    [riscv] Fix compilation error and disassembling error when enabling the RISC-V C extension

    Change-Id: I34a930f7bcda514698ce64d132cbe05fa32b323c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6934163
    Reviewed-by: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
    Reviewed-by: Kasper Lund <kasperl@rivosinc.com>
    Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#102431}

Refs: v8/v8@209d2db
Co-authored-by: kxxt <rsworktech@outlook.com>
PR-URL: nodejs#61322
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 merged commit e326df7 into nodejs:v25.x-staging Jan 20, 2026
@aduh95

ghost commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Landed in e326df7

@kxxt
kxxt deleted the riscv-c-ext branch January 20, 2026 12:49
@aduh95 aduh95 added the backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. label Apr 4, 2026
@aduh95

ghost commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Do we want/need this on 24.x? If so, we'd need a manual backport. If not, we can add the dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. label

@kxxt

ghost commented Apr 4, 2026

Copy link
Copy Markdown
Member Author

Do we want/need this on 24.x? If so, we'd need a manual backport. If not, we can add the dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. label

IIRC it is only meant for 25, but I will double check it.

@aduh95 aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. and removed backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. labels Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants