Repository navigation
Conversation
Signed-off-by: DaveT1991 <dawoodaljanaby@gmail.com>
Collaborator
|
Review requested:
|
|
It does not do the trick unfortunately |
juanarbol
force-pushed
the
v22.x-staging
branch
2 times, most recently
from
July 19, 2026 22:51
26f3d8c to
a6b3a35
Compare
marco-ippolito
force-pushed
the
v22.x-staging
branch
from
July 29, 2026 13:35
a6b3a35 to
400e833
Compare
juanarbol
force-pushed
the
v22.x-staging
branch
2 times, most recently
from
August 21, 2026 17:53
6543035 to
7c2df5d
Compare
jrsells
added a commit
to Asana/node
that referenced
this pull request
Nov 15, 2026
Since 22.22.2, AstRawString::AsArrayIndex() decodes cached array indices with HashSeed(ReadOnlyHeap::GetReadOnlyRoots()), which only exists with V8_SHARED_RO_HEAP. configure turns the shared read-only heap off for --experimental-enable-pointer-compression builds, so ours don't compile (nodejs#62631). The proposed upstream fix, nodejs#62664, calls a GetReadOnlyRoots() that V8 12.4 doesn't have. Without a shared read-only heap there's no process-wide hash seed to decode the cached index with, so parse the index from the string's digits, as the function already does for longer strings. For strings short enough to cache an index, the result is the same.
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a V8 build regression on the
v22.xline when Node is configured with--disable-shared-readonly-heap.Problem
Building Node 22.22.2 without
V8_SHARED_RO_HEAPfails indeps/v8/src/ast/ast-value-factory.ccbecause the code tries to retrieve read-only roots with a shared-RO-heap accessor that is not available in that configuration.Root cause
The backported V8 change switched
AstRawString::AsArrayIndex()to decode cached array indexes using a hash seed from read-only roots, but this call site used the wrong accessor for non-shared-readonly-heap builds.Fix
deps/v8/src/ast/ast-value-factory.ccwith the currentmainbranch implementationHashSeed(GetReadOnlyRoots())at the call siteTesting
git diff --checkmainbranch implementationFixes: #62631