Repository navigation
tools: restore FIPS testing with default OpenSSL - #67248
Merged
Merged
Conversation
OpenSSL 4.1 falls back to SHA-256 for the md5 command when MD5 is unavailable. Select MD5 explicitly through dgst to avoid a false failure in the negative install check. Use the default shared OpenSSL version for FIPS again instead of pinning it to 3.5. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Contributor
Changelog@@ -1270,14 +1270,14 @@
-/nix/store/dzj8hnb7knc7vzlz8xrdyxzszyq4y6cr-openssl-fips-3.5.9 (aarch64-darwin)
-/nix/store/w6l20jpmbmf82gwl8jgh68qjfhk96g6q-openssl-fips-3.5.9 (aarch64-linux)
-/nix/store/3gdjbn9n6ian5mdsab4f7g2s7wmszyyi-openssl-fips-3.5.9 (x86_64-darwin)
-/nix/store/4j3472s1m4vijkwyjpnfdcmnizlbrrm8-openssl-fips-3.5.9 (x86_64-linux)
-/nix/store/y6hm20q4hn729d6rfj28k72789dmgwia-openssl-fips-3.5.9-bin (aarch64-darwin)
-/nix/store/iaabj8kmhwmmz991zhif7hz4jmnf6kpv-openssl-fips-3.5.9-bin (aarch64-linux)
-/nix/store/7gx71fgk8ag35a4p058rszc7adnsxlp1-openssl-fips-3.5.9-bin (x86_64-darwin)
-/nix/store/53rw9b68955qwp7al4sqlq9b16x6s78n-openssl-fips-3.5.9-bin (x86_64-linux)
-/nix/store/lvjbpfa1xk0x7gamqh3kmgm4fblcifgj-openssl-fips-3.5.9-debug (aarch64-linux)
-/nix/store/sjy3kb2xvm2mwnfqx813balngwlkvfyz-openssl-fips-3.5.9-debug (x86_64-linux)
-/nix/store/swhas9j48w7mdd0fsf7k7j6fb6nnfci5-openssl-fips-3.5.9-dev (aarch64-darwin)
-/nix/store/y4gg79a8zbhf86n7srin0wjbwwbgp8mk-openssl-fips-3.5.9-dev (aarch64-linux)
-/nix/store/pzlp6vcspp023f8293sn6gl0gj3945l1-openssl-fips-3.5.9-dev (x86_64-darwin)
-/nix/store/hhv54pfsb8q43kshzkk7f90b1h2w7wj3-openssl-fips-3.5.9-dev (x86_64-linux)
+/nix/store/qvnmz8mjqxq3bd87hlx512fd54ha9xc1-openssl-fips-4.1.0 (aarch64-darwin)
+/nix/store/h580k5701879czn5k9rp3imdcyj5pz2c-openssl-fips-4.1.0 (aarch64-linux)
+/nix/store/r96q912iwif1qnz8bh945qa3frspxbcj-openssl-fips-4.1.0 (x86_64-darwin)
+/nix/store/i5gvxk7h9g7g6sv3glph6d2548vmms18-openssl-fips-4.1.0 (x86_64-linux)
+/nix/store/mqjp4kc78nnvgfrfry2j4v9zz2jqdm53-openssl-fips-4.1.0-bin (aarch64-darwin)
+/nix/store/nzyppkzs4lgnin51kyjfnxzw9qvv2cr9-openssl-fips-4.1.0-bin (aarch64-linux)
+/nix/store/c59z7a6rqg4qw466qf8bjfw7g4ixpgnv-openssl-fips-4.1.0-bin (x86_64-darwin)
+/nix/store/2dn3nkzzxihrbnga8ww54340x5l5a41h-openssl-fips-4.1.0-bin (x86_64-linux)
+/nix/store/8qdxlf15g1ma6na38cc0h4vzgh7fzghy-openssl-fips-4.1.0-debug (aarch64-linux)
+/nix/store/mxj717clmp6hjif6gfiqmvpxpm96qlwx-openssl-fips-4.1.0-debug (x86_64-linux)
+/nix/store/78ywadi2raiq2mcygslckh6dgld3z60a-openssl-fips-4.1.0-dev (aarch64-darwin)
+/nix/store/3c55gw7hd4pymhmklz2q73firwhc9rc6-openssl-fips-4.1.0-dev (aarch64-linux)
+/nix/store/2w6bzizd8bfgimin61c3fylh0f48iv14-openssl-fips-4.1.0-dev (x86_64-darwin)
+/nix/store/0pj4b8n6j2pnl70871pqa7ixx9n9pih6-openssl-fips-4.1.0-dev (x86_64-linux) |
Member
Author
|
blocked on #67250 |
Contributor
Changelog@@ -1270,14 +1270,14 @@
-/nix/store/dzj8hnb7knc7vzlz8xrdyxzszyq4y6cr-openssl-fips-3.5.9 (aarch64-darwin)
-/nix/store/w6l20jpmbmf82gwl8jgh68qjfhk96g6q-openssl-fips-3.5.9 (aarch64-linux)
-/nix/store/3gdjbn9n6ian5mdsab4f7g2s7wmszyyi-openssl-fips-3.5.9 (x86_64-darwin)
-/nix/store/4j3472s1m4vijkwyjpnfdcmnizlbrrm8-openssl-fips-3.5.9 (x86_64-linux)
-/nix/store/y6hm20q4hn729d6rfj28k72789dmgwia-openssl-fips-3.5.9-bin (aarch64-darwin)
-/nix/store/iaabj8kmhwmmz991zhif7hz4jmnf6kpv-openssl-fips-3.5.9-bin (aarch64-linux)
-/nix/store/7gx71fgk8ag35a4p058rszc7adnsxlp1-openssl-fips-3.5.9-bin (x86_64-darwin)
-/nix/store/53rw9b68955qwp7al4sqlq9b16x6s78n-openssl-fips-3.5.9-bin (x86_64-linux)
-/nix/store/lvjbpfa1xk0x7gamqh3kmgm4fblcifgj-openssl-fips-3.5.9-debug (aarch64-linux)
-/nix/store/sjy3kb2xvm2mwnfqx813balngwlkvfyz-openssl-fips-3.5.9-debug (x86_64-linux)
-/nix/store/swhas9j48w7mdd0fsf7k7j6fb6nnfci5-openssl-fips-3.5.9-dev (aarch64-darwin)
-/nix/store/y4gg79a8zbhf86n7srin0wjbwwbgp8mk-openssl-fips-3.5.9-dev (aarch64-linux)
-/nix/store/pzlp6vcspp023f8293sn6gl0gj3945l1-openssl-fips-3.5.9-dev (x86_64-darwin)
-/nix/store/hhv54pfsb8q43kshzkk7f90b1h2w7wj3-openssl-fips-3.5.9-dev (x86_64-linux)
+/nix/store/qvnmz8mjqxq3bd87hlx512fd54ha9xc1-openssl-fips-4.1.0 (aarch64-darwin)
+/nix/store/h580k5701879czn5k9rp3imdcyj5pz2c-openssl-fips-4.1.0 (aarch64-linux)
+/nix/store/r96q912iwif1qnz8bh945qa3frspxbcj-openssl-fips-4.1.0 (x86_64-darwin)
+/nix/store/i5gvxk7h9g7g6sv3glph6d2548vmms18-openssl-fips-4.1.0 (x86_64-linux)
+/nix/store/mqjp4kc78nnvgfrfry2j4v9zz2jqdm53-openssl-fips-4.1.0-bin (aarch64-darwin)
+/nix/store/nzyppkzs4lgnin51kyjfnxzw9qvv2cr9-openssl-fips-4.1.0-bin (aarch64-linux)
+/nix/store/c59z7a6rqg4qw466qf8bjfw7g4ixpgnv-openssl-fips-4.1.0-bin (x86_64-darwin)
+/nix/store/2dn3nkzzxihrbnga8ww54340x5l5a41h-openssl-fips-4.1.0-bin (x86_64-linux)
+/nix/store/8qdxlf15g1ma6na38cc0h4vzgh7fzghy-openssl-fips-4.1.0-debug (aarch64-linux)
+/nix/store/mxj717clmp6hjif6gfiqmvpxpm96qlwx-openssl-fips-4.1.0-debug (x86_64-linux)
+/nix/store/78ywadi2raiq2mcygslckh6dgld3z60a-openssl-fips-4.1.0-dev (aarch64-darwin)
+/nix/store/3c55gw7hd4pymhmklz2q73firwhc9rc6-openssl-fips-4.1.0-dev (aarch64-linux)
+/nix/store/2w6bzizd8bfgimin61c3fylh0f48iv14-openssl-fips-4.1.0-dev (x86_64-darwin)
+/nix/store/0pj4b8n6j2pnl70871pqa7ixx9n9pih6-openssl-fips-4.1.0-dev (x86_64-linux) |
aduh95
approved these changes
Nov 6, 2026
Collaborator
|
Landed in f15ec18 |
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2026
OpenSSL 4.1 falls back to SHA-256 for the md5 command when MD5 is unavailable. Select MD5 explicitly through dgst to avoid a false failure in the negative install check. Use the default shared OpenSSL version for FIPS again instead of pinning it to 3.5. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #67248 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 15, 2026
The pbkdf2() call that keeps the only threadpool worker busy used a 6-byte password and a 4-byte salt. OpenSSL 4 FIPS rejects those, so the derivation failed at once and freed the worker. The queued stat could then start before req.cancel() ran, and it completed without ECANCELED. Use inputs that meet the FIPS minimums and check that the derivation succeeds. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com> PR-URL: #67449 Refs: #67248 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2026
The pbkdf2() call that keeps the only threadpool worker busy used a 6-byte password and a 4-byte salt. OpenSSL 4 FIPS rejects those, so the derivation failed at once and freed the worker. The queued stat could then start before req.cancel() ran, and it completed without ECANCELED. Use inputs that meet the FIPS minimums and check that the derivation succeeds. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com> PR-URL: #67449 Refs: #67248 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 17, 2026
The pbkdf2() call that keeps the only threadpool worker busy used a 6-byte password and a 4-byte salt. OpenSSL 4 FIPS rejects those, so the derivation failed at once and freed the worker. The queued stat could then start before req.cancel() ran, and it completed without ECANCELED. Use inputs that meet the FIPS minimums and check that the derivation succeeds. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com> PR-URL: #67449 Refs: #67248 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL 4.1 falls back to SHA-256 for the md5 command when MD5 is unavailable. Select MD5 explicitly through dgst to avoid a false failure in the negative install check.
Use the default shared OpenSSL version for FIPS again instead of pinning it to 3.5.