Repository navigation
Conversation
Signed-off-by: Tim Perry <pimterry@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67558 +/- ##
==========================================
+ Coverage 90.67% 90.70% +0.03%
==========================================
Files 800 801 +1
Lines 280889 280730 -159
Branches 54274 54192 -82
==========================================
- Hits 254684 254650 -34
+ Misses 16295 16259 -36
+ Partials 9910 9821 -89
🚀 New features to boost your workflow:
|
Clean up & (hopefully) deflake the new test
jasnell
approved these changes
Nov 18, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9113 allows servers to send a response and then ask the client to cancel their request:
The client side of this wasn't fully covered in #63249. We previously always destroyed the stream when receiving a reset, and just used the code to decide whether it was clean or an error, but the destroy meant that we discarded the pending response.
This PR fixes that: if a server cancels a client's request with a RST_STREAM after sending a full response, the client now keeps the response (and skips future writes). This extends the fix from #67553 to resolve #66693 on main and v27 as well.