Skip to content

Add correct shared library naming on OS X - #7687

Closed
sxa wants to merge 1 commit into
nodejs:masterfrom
sxa:sharedlib-osx
Closed

sxa wants to merge 1 commit into
nodejs:masterfrom
sxa:sharedlib-osx

Conversation

@sxa

@sxa sxa commented Jul 12, 2016 •

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Build system

Description of change

The build system currently creates a shared library on OS/X with the same name as on Linux
i.e. libnode.so.48. This is inconsistent with the conventions on OS/X which uses libnode.48.dylib
This change modifies the build process and install.py (used by make binary) to build with the
correct name on OS/X when the --shared configure parameter is used. Without these changes,
"make binary" with CONFIG_FLAGS=--shared fails on the install.py step

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. macos Issues and PRs related to the macOS platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants