New pull request overview page in public preview 🚀 #212186
Replies: 152 comments 66 replies
|
I have a few pieces of feedback, broken out here to be easier to respond to. I'd also be happy to split this into multiple comments if that would be easier to work with. Firstly, I like the redesign of the merge box and moving it to the top. Being able to see the status at a glance without having to scroll, no matter how active the PR is, is a huge win. On the other hand, I don't like the redesign of the rest of the page as much, for a few reasons. Here they are in order of least-to-most blocking for my workflow: I find newest-first sorting really hard to read (I'm in full support of having it be an option, and thank you for letting us change it back, but I think it's an odd default).
And finally the biggest issue for me is the split timelines. I use the activity timeline a lot to see what has actually happened to a PR since I last reviewed it, especially for force pushes, so having that information inline with the review and comment history is important to my workflow. Splitting them out means that now if I want to see what happened since I last reviewed I need to manually filter the activity list in my head. Additionally, there is no longer an easy link to view a force push's diff, which is a view I use extremely frequently due to our PR process. |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
very cool design, i really like it 👍 |
|
I don't like it. |
|
Can we get rid of the scroll jump after approving a PR? In 90% of cases, my next action after clicking Approve is to merge, but the merge button is now at the top. |
|
I would love if it can show the project fields like iteration and when they change on PR. We manage testing on PR so when it moves from swimlane to swimlane that is visible but other project fields are not. |
|
Please keep the diff stat in a fixed position, independent of branch name length, so it's easier to compare stacked PR sizes. |
|
I assume that this is progressively rolling out to users? I've not seen the |
|
It would be useful to be able to pin a comment to the top. There are often comments or bot feedback that get lost in the noise that are important top level content. |
|
I’d love a "back to top" button 😄 Both in the |
|
Proposal: Keep the classic chronological timeline as the default, with optional sorting, event filters, and dual merge controls
A few adjustments would give us the best of both worlds:
|
|
I can't find where I can revert the order of the view to normal top-down is ascending in time. I keep getting confused, because threads run top-down yet the overall flow is bottom-up, and it's oddly mentally taxing. I'm pretty sure there should be a way to revert to the old order, but I can't find it. I do think that the goal of making the "most recent" remarks more accessible is great, but I don't think this approach is an overall improvement over the old mechanism that collapsed long sections. I see no use for the expandable side panel, it's also confusing that there are two buttons that open and close the same panel. I really like the ability to immediately submit a review at the top. Often I look at the files, leave comments, then go back to the conversation view, and discuss those comments with colleagues, and once we're done, I want to approve / request changes. Now I no longer have to go back to the files view to do that, and it's a great improvement. The new checks, comments, approvals at the top are great, as is the ability to auto-merge and update the branch. But the top-down order of the timeline is not doing it for me. I'd rather have some easier way to go to the bottom of the page and have some more relevant controls be sticky on the top of the screen. EDIT: I just noticed force pushes are no longer shown. That's insane. The code could be completely changed at some point in time, and it's just ignored! We use force pushes a lot, and it's highly desirable to see them. |
|
Top posting has been bad since email days, & it’s just as impossible to read here. At least let users set their default position so they don’t have to read backwards. A classic:
I’ll be going back to the old view (& praying Nixpkgs will finally move to a different platform) |
|
The verified badge on commits which are signed properly doesn't seem to appear on the new view. |
|
Videos uploaded together don't render as players in the PR description (new Overview preview) What happened: The inserted links were placed one right after the other, with no blank line between them, so they rendered as plain text links instead of embedded videos. What I tried:
Expected: Details:
The same files worked fine on re-upload, so this looks related to how links are inserted when multiple files are uploaded together in the new experience. |
|
Moving the Merge button to the very top so folks can click without reading all the way down reminds me of a prophetic 1991 synth-pop song ("Press the Button" by Technology):
Putting the button at the bottom forced reviewers to actually read the code and comments first. Putting it on top turns code review into blind button-pushing. |
|
The new Overview does not allow resetting reviewer approvals. The problem is when I reset my approval using the old view, the new overview still displays the approval as if it wasn't reset. This seems like a bug because it's displaying inaccurately and out-of-date at that point. Has anyone found a way to reset the approval in the new UI and if so where is it displayed? |
|
How can I dismiss a review in the new interface? |
|
Like others here, I like that the summary is at the top of the page, but I appear to have lost 2 abilities with this new UI:
|
|
Bug: deep links to PR comments don't scroll to the comment Opening a link to a specific comment - (example) - scroll stops well short of the comment. Most likely the page scrolls to the anchor before everything above it has rendered. |
|
Despite not finding the information as easily as beofre, it's looking much tidier and nicer. I assume most of it is force of habit, but one thing I haven't been able to find is that previously in the old design I had information of the remaining suitable approvers (codeowners) in the So if an approval make other reviewers redundant, these were filtered from this list, so that you could visualize the approves that you still needede to get ready to merge the PR. Now I see the list of codeowners, but I do not see the remaining required ones. |















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
On a long pull request, checking what’s blocking often means scrolling past dozens of comments and timeline events just to reach the merge box. And once you’re there, you still need to work out what to do next. As people need to review more and more pull requests, time spent scrolling adds up. So we’ve begun to rethink the entire experience, beginning with addressing a familiar challenge: finding what’s blocking progress and determining what to do next.
Today, we’re introducing the Overview page as an opt-in public preview, with rollout continuing through the weekend. It brings merge status and next available actions to the top of the page in a compact readiness summary. It’s the first step toward making pull requests easier to follow as code, conversations, and reviews evolve.
The merge box, distilled
We’re starting with the merge box, the place developers go to see whether a pull request can move forward. Rather than just moving it higher, we’ve also redesigned it to show the same information in less than half the space.
Start with the summary, then follow the detail that matters to your next step (e.g., get to failing checks, see who still needs to approve, or open the relevant comments).
Keep your place. Focus your attention.
This first preview also introduces more ways to catch up on activity and focus the conversation so you can spend less time finding your place.
You can also mark a draft ready for review or close a pull request from the header, with available actions depending on your permissions.
Try the new overview
To join, select the ✨ Try the Overview page button in the header. We’re opening this preview early so you can try the new direction on your own pull requests and help shape what comes next. You can use the same menu to return to the classic overview during the preview.
🌟 Help shape what comes next
This preview is very much a starting point, not the finished pull request experience. Try it on your next pull request. What is easier to find? Where do you still lose context? What sends you back to the classic overview?
Join the discussion and leave feedback in the comments below!
All reactions