Repository navigation
Description
Description
array_multisort() and the usort() family keep the state of the sort in progress in thread globals: ARRAYG(multisort_func) and BG(user_compare_fci) / BG(user_compare_fci_cache). Each call saves the previous value on entry and restores it on return, which assumes calls nest. A Fiber suspended inside a comparison (in __toString(), a user comparator, or an error handler) breaks that assumption. If another fiber sorts in the meantime, and the two sorts finish in a different order than they started, the sort that is still running uses the other call's state.
array_multisort() crashes. The first sort returns and puts NULL back into ARRAYG(multisort_func). The second sort's next comparison then calls through it:
<?php
class S {
public function __construct(public string $v, public bool $park = false) {}
public function __toString(): string {
if ($this->park && Fiber::getCurrent()) { $this->park = false; Fiber::suspend(); }
return $this->v;
}
}
$a = [new S('c', true), new S('b'), new S('a'), new S('d')];
$b = [new S('z', true), new S('y'), new S('x'), new S('w')];
$fa = new Fiber(function () use (&$a) { array_multisort($a, SORT_STRING); echo "A done\n"; });
$fb = new Fiber(function () use (&$b) { array_multisort($b, SORT_STRING); echo "B done\n"; });
$fa->start(); echo "A parked\n";
$fb->start(); echo "B parked\n";
$fa->resume();
$fb->resume();
echo "survived\n";Resulted in this output:
A parked
B parked
A done
Segmentation fault
(exit status 139)
But I expected this output instead:
A parked
B parked
A done
B done
survived
With three interleaved calls, a sort can also be left calling through another call's comparison table after that table has been freed.
usort() calls the other sort's comparator, then fails.
<?php
$mk = function (string $who) {
$first = true;
return function ($x, $y) use ($who, &$first) {
echo "cmp($who)\n";
if ($first && Fiber::getCurrent()) { $first = false; Fiber::suspend(); }
return $x <=> $y;
};
};
$a = [3, 1, 2]; $b = [30, 10, 20];
$fa = new Fiber(function () use (&$a, $mk) { usort($a, $mk('A')); echo "A done\n"; });
$fb = new Fiber(function () use (&$b, $mk) { usort($b, $mk('B')); echo "B done\n"; });
$fa->start(); $fb->start();
$fa->resume();
try { $fb->resume(); } catch (\Throwable $e) { echo get_class($e), ': ', $e->getMessage(), "\n"; }
echo json_encode([$a, $b]), "\n";Resulted in this output (A's sort runs B's comparator, then B's sort finds no callback):
cmp(A)
cmp(B)
cmp(B)
cmp(B)
A done
Error: Invalid callback , no array or string given
[[1,2,3],[10,30,20]]
But I expected this output instead:
cmp(A)
cmp(B)
cmp(A)
...
A done
B done
[[1,2,3],[10,20,30]]
The save and restore are in ext/standard/array.c: array_multisort() (old_multisort_func / ARRAYG(multisort_func)) and PHP_ARRAY_CMP_FUNC_BACKUP() / PHP_ARRAY_CMP_FUNC_RESTORE(). The code is the same on current master.
Possible fixes:
- block fiber switching for the duration of the sort with
zend_fiber_switch_block()/zend_fiber_switch_unblock(), as some other engine callbacks already do. AFiber::suspend()inside a comparison would then throwFiberErrorinstead of corrupting the state; - or keep this state per fiber instead of per thread.
Reproduced on both NTS and ZTS builds (official Docker images php:8.5-cli-alpine, php:8.4-zts-alpine3.24, php:8.5-zts-alpine3.24).
PHP Version
PHP 8.5.12 (cli) (built: Nov 5 2026 18:54:25) (NTS)
Copyright (c) The PHP Group
Built by https://github.com/docker-library/php
Zend Engine v4.5.12, Copyright (c) Zend Technologies
with Zend OPcache v8.5.12, Copyright (c), by Zend Technologies
Also reproduced with:
PHP 8.4.27 (cli) (built: Nov 5 2026 18:56:54) (ZTS)
Operating System
Alpine Linux 3.24 (Docker)
Activity
Block fiber switches in array_multisort, refuse unbounded channel waits