Skip to content

Fixed getElementsByTagNameNS not filtering on default namespace (bug #67474) - #2267

Closed
aboks wants to merge 2 commits into
php:PHP-7.0from
aboks:bug67474
Closed

aboks wants to merge 2 commits into
php:PHP-7.0from
aboks:bug67474

Conversation

@aboks

@aboks aboks commented Jan 2, 2017

Copy link
Copy Markdown
Contributor

This bug was caused by the fact that dom_get_elements_by_tag_name_ns_raw
uses an empty string to filter on the default namespace (as NULL means
'no filter'), whereas in the node itself the default namespace is
signalled by nodep->ns being NULL.

aboks added 2 commits January 2, 2017 11:46
This bug was caused by the fact that dom_get_elements_by_tag_name_ns_raw
uses an empty string to filter on the default namespace (as NULL means
'no filter'), whereas in the node itself the default namespace is
signalled by nodep->ns being null.
@krakjoe krakjoe added the Bug label Jan 2, 2017
@krakjoe

krakjoe commented Jan 2, 2017

Copy link
Copy Markdown
Member

Merged a895592

Thanks :)

@krakjoe krakjoe closed this Jan 2, 2017
php-pulls pushed a commit that referenced this pull request Jan 2, 2017
php-pulls pushed a commit that referenced this pull request Jan 2, 2017
* PHP-7.0:
  news entry for PR #2267
  Fixed #67474 (getElementsByTagNameNS and default namespace)
  Add (failing) testcase for bug #67474
php-pulls pushed a commit that referenced this pull request Jan 2, 2017
php-pulls pushed a commit that referenced this pull request Jan 2, 2017
* PHP-7.1:
  news entry for PR #2267
  Fixed #67474 (getElementsByTagNameNS and default namespace)
  Add (failing) testcase for bug #67474
php-pulls pushed a commit that referenced this pull request Jan 2, 2017
@aboks
aboks deleted the bug67474 branch January 2, 2017 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants