Skip to content

enable cli opcache starting with php 7.1 - #2290

Closed
staabm wants to merge 3 commits into
php:PHP-7.1from
staabm:patch-3
Closed

staabm wants to merge 3 commits into
php:PHP-7.1from
staabm:patch-3

Conversation

@staabm

@staabm staabm commented Jan 9, 2017

Copy link
Copy Markdown
Contributor

as discussed in #2238 (comment)

@staabm
staabm changed the base branch from master to PHP-7.1 January 9, 2017 09:28
@staabm

staabm commented Jan 9, 2017

Copy link
Copy Markdown
Contributor Author

failing travis build looks unrelated:
This is the test message -- configure: error: mcrypt.h not found. Please reinstall libmcrypt.

php-pulls pushed a commit that referenced this pull request Jan 9, 2017
@krakjoe

krakjoe commented Jan 9, 2017

Copy link
Copy Markdown
Member

Merged 71fe529

Thanks.

@krakjoe krakjoe closed this Jan 9, 2017
php-pulls pushed a commit that referenced this pull request Jan 9, 2017
* PHP-7.1:
  merge PR #2290: enable opcache in CLI in 7.1+
@staabm
staabm deleted the patch-3 branch January 9, 2017 11:04
@nikic

nikic commented May 14, 2017

Copy link
Copy Markdown
Member

There's been some complaints that this negatively impacts memory usage and startup time of PHP on CLI. Especially without the file cache, whether or not having opcache enabled on CLI is beneficial will depend a lot on the script, how many backing files it has and how long it runs. I would suggest reverting this change.

@weltling

Copy link
Copy Markdown
Contributor

I'd be telling same. The file cache only could be useful at least, but it cannot be enabled by default and thus it cannot be used Python alike. Under this circumstances, enabling on CLI by defauls seems rather an overkill having more negative impact than improvement.

Thanks.

php-pulls pushed a commit that referenced this pull request Jun 2, 2017
This reverts commit 71fe529.

Without the file cache (which is not enabled by default), this has
non-trivial impact on the startup time. It also significantly
increases the baseline memory usage of PHP on CLI.
@nikic

nikic commented Jun 2, 2017

Copy link
Copy Markdown
Member

Reverted via e9ff1fa.

dstogov added a commit to zendtech/php-src that referenced this pull request Jun 5, 2017
* master: (89 commits)
  Replace ASN1_STRING_data with ASN1_STRING_get0_data
  Fix leak in WDDX serialization
  Travis: Use opcache in release build
  Implemented FR #71520
  Fixed bug #69373
  Fix bug #74607: Don't check for bi-directional compatibility in traits
  Fix bug #55407
  Fixed bug #73473: Stack Buffer Overflow in msgfmt_parse_message
  openssl_pkcs12_read: add missing BIO_free
  Add basic test for posix_setegid function
  Set timezone for intl/test/bug74298.phpt
  Revert "merge PR php#2290: enable opcache in CLI in 7.1+"
  PCRE_EXTRA_MARK is useful only for preg_replace_callbakc(). Removed branch expectations.
  Added support for PCRE JIT fast path API
  Escape value passed to exec()
  Ignore spurious stderr output from lsof
  ZVAL_COPY_UNREF() micro-optimization
  test for ErrorException::getSeverity();
  improve dns (checkdnsrr) test coverage
  test to function forward_static_call_array();
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants