Repository navigation
Fix ZTS build on OpenBSD - #25557
Open
osbre wants to merge 1 commit into
Open
Fix ZTS build on OpenBSD#25557osbre wants to merge 1 commit into
osbre wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OpenBSD, TSRM should use the default TLS model, the same as it already does on FreeBSD and NetBSD.
OpenBSD uses emulated TLS, so there is no
_tsrm_ls_cachesymbol. On aarch64,tsrm_get_ls_cache_tcb_offset()still references it in inline asm, and the link fails:This PR adds OpenBSD to that list to fix the build.
Tested with a
--enable-ztsbuild on OpenBSD -current/arm64.